-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable adding and removing SSO config from web #4097
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4097 +/- ##
==========================================
- Coverage 38.47% 38.45% -0.03%
==========================================
Files 723 723
Lines 33219 33242 +23
Branches 4879 4888 +9
==========================================
Hits 12782 12782
- Misses 19813 19836 +23
Partials 624 624
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
i'd also add an option to remove/reset the sso config (not sure if emptying the text field is a good enough ux), tho that seems out of scope
Emptying the text field won't work actually, because the value is |
Deletion accompanied by #4098 |
Deployed to https://sso.dev.quilttest.com/admin |
Co-authored-by: Alexei Mochalov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tho i feel like we need a confirmation dialog for the deletion
Description
Enable not only editing but also adding and removing the SSO config from Admin UI.
TODO