Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adding and removing SSO config from web #4097

Merged
merged 18 commits into from
Aug 16, 2024
Merged

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 14, 2024

Description

Enable not only editing but also adding and removing the SSO config from Admin UI.

image

TODO

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 52 lines in your changes missing coverage. Please review.

Project coverage is 38.45%. Comparing base (ec1091f) to head (dc6976d).
Report is 2 commits behind head on master.

Files Patch % Lines
...g/app/containers/Admin/UsersAndRoles/SsoConfig.tsx 0.00% 44 Missing ⚠️
...talog/app/containers/Admin/UsersAndRoles/Roles.tsx 0.00% 5 Missing ⚠️
catalog/app/utils/GraphQL/Provider.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4097      +/-   ##
==========================================
- Coverage   38.47%   38.45%   -0.03%     
==========================================
  Files         723      723              
  Lines       33219    33242      +23     
  Branches     4879     4888       +9     
==========================================
  Hits        12782    12782              
- Misses      19813    19836      +23     
  Partials      624      624              
Flag Coverage Δ
api-python 90.85% <ø> (ø)
catalog 11.44% <3.70%> (-0.02%) ⬇️
lambda 87.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus requested review from nl0 and sir-sigurd August 15, 2024 09:14
nl0
nl0 previously approved these changes Aug 15, 2024
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
i'd also add an option to remove/reset the sso config (not sure if emptying the text field is a good enough ux), tho that seems out of scope

@fiskus
Copy link
Member Author

fiskus commented Aug 15, 2024

Emptying the text field won't work actually, because the value is "required" now

@fiskus fiskus changed the title Enable adding SSO config from web Enable adding and removing SSO config from web Aug 15, 2024
@fiskus
Copy link
Member Author

fiskus commented Aug 15, 2024

Deletion accompanied by #4098

@fiskus fiskus requested a review from nl0 August 15, 2024 16:20
@fiskus
Copy link
Member Author

fiskus commented Aug 15, 2024

Deployed to https://sso.dev.quilttest.com/admin

nl0
nl0 previously approved these changes Aug 15, 2024
@fiskus fiskus enabled auto-merge August 15, 2024 21:04
@sir-sigurd sir-sigurd requested a review from nl0 August 16, 2024 07:26
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tho i feel like we need a confirmation dialog for the deletion

@fiskus fiskus added this pull request to the merge queue Aug 16, 2024
Merged via the queue into master with commit 095dbc9 Aug 16, 2024
36 of 38 checks passed
@fiskus fiskus deleted the enable-sso-config-editing branch August 16, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants