Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify condition for rendering Quilt manifests, allowing to render other types of files in .quilt/packages/ #3816

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Specify condition for rendering Quilt manifests, allowing to render other types of files in .quilt/packages/ #3816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
263fc59
Only files without extension are Quilt manifests
fiskus Dec 11, 2023
65cbcb8
add changelog entry
fiskus Dec 11, 2023
37b31a8
Merge branch 'master' into fix-showing-parquet-in-quilt-packages
fiskus Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion catalog/app/components/Preview/loaders/Manifest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { extname } from 'path'

import hljs from 'highlight.js'
import * as R from 'ramda'
import * as React from 'react'
Expand All @@ -10,7 +12,9 @@ import { PreviewData, PreviewError } from '../types'
import * as Text from './Text'
import * as utils from './utils'

export const detect = R.startsWith('.quilt/packages/')
const hasNoExt = (key: string) => !extname(key)

export const detect = R.allPass([R.startsWith('.quilt/packages/'), hasNoExt])

const hl = (language: string) => (contents: string) =>
hljs.highlight(contents, { language }).value
Expand Down
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Entries inside each section should be ordered by type:
* [Changed] Unify per-bucket and global search ([#3613](https://github.com/quiltdata/quilt/pull/3613))
* [Changed] Allow use of <br /> in Markdown ([#3720](https://github.com/quiltdata/quilt/pull/3720))
* [Changed] Faceted search ([#3712](https://github.com/quiltdata/quilt/pull/3712))
* [Changed] Specify condition for rendering Quilt manifests, allowing to render other types of files in `.quilt/packages/` ([#3816](https://github.com/quiltdata/quilt/pull/3816))

# 5.3.1 - 2023-05-02
## Python API
Expand Down