Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify condition for rendering Quilt manifests, allowing to render other types of files in .quilt/packages/ #3816

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Specify condition for rendering Quilt manifests, allowing to render other types of files in .quilt/packages/ #3816

merged 3 commits into from
Dec 12, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Dec 11, 2023 •
edited
Loading

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@fiskus fiskus changed the title Specify condition for rendering Quilt manifests, allowing to render other types of files in .quilt/packages/ Specify condition for rendering Quilt manifests, allowing to render other types of files in .quilt/packages/ Dec 11, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6a44d3c) 35.50% compared to head (37b31a8) 35.50%.

Files Patch % Lines
...atalog/app/components/Preview/loaders/Manifest.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3816      +/-   ##
==========================================
- Coverage   35.50%   35.50%   -0.01%     
==========================================
  Files         711      711              
  Lines       31236    31238       +2     
  Branches     4670     4670              
==========================================
  Hits        11091    11091              
- Misses      18991    18993       +2     
  Partials     1154     1154
Flag Coverage Δ
api-python 91.22% <ø> (ø)
catalog 10.61% <0.00%> (-0.01%) ⬇️
lambda 86.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus requested a review from nl0 December 11, 2023 17:45
drernie
drernie approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@drernie drernie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fiskus fiskus added this pull request to the merge queue Dec 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2023
@fiskus fiskus added this pull request to the merge queue Dec 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2023
@fiskus fiskus added this pull request to the merge queue Dec 12, 2023
Merged via the queue into master with commit 1771a07 Dec 12, 2023
40 of 42 checks passed
@fiskus fiskus deleted the fix-showing-parquet-in-quilt-packages branch December 12, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drernie drernie drernie approved these changes

@nl0 nl0 Awaiting requested review from nl0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiskus @drernie