Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand troubleshooting docs, add ESM, IAM, S3 commands #3498

Merged
merged 8 commits into from
Jun 20, 2023

Conversation

akarve
Copy link
Member

@akarve akarve commented Jun 14, 2023

No description provided.

@akarve akarve requested a review from sir-sigurd June 14, 2023 23:31
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #3498 (f502f4d) into master (d53e94a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3498      +/-   ##
==========================================
+ Coverage   28.29%   28.31%   +0.01%     
==========================================
  Files         641      641              
  Lines       25936    25936              
  Branches     4418     4418              
==========================================
+ Hits         7339     7344       +5     
+ Misses      17425    17420       -5     
  Partials     1172     1172              
Flag Coverage Δ
api-python 91.32% <ø> (+0.08%) ⬆️
catalog 10.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akarve akarve marked this pull request as ready for review June 14, 2023 23:37
Copy link
Member

@sir-sigurd sir-sigurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally changes are OK, but I think the structure of the document is becoming somewhat loose:

  • I'm not sure it worth to make customer collect all this information (specifically for event source mapping) just for every problem
  • re-enabling event source mapping is not log collection 🙂

docs/Troubleshooting.md Outdated Show resolved Hide resolved
docs/Troubleshooting.md Outdated Show resolved Hide resolved
docs/Troubleshooting.md Outdated Show resolved Hide resolved
docs/Troubleshooting.md Outdated Show resolved Hide resolved
docs/Troubleshooting.md Outdated Show resolved Hide resolved
@akarve akarve requested a review from sir-sigurd June 16, 2023 18:21
docs/Troubleshooting.md Outdated Show resolved Hide resolved
@akarve akarve merged commit 58581bf into master Jun 20, 2023
@akarve akarve deleted the troubleshoot-cmds branch June 20, 2023 20:05
nl0 added a commit that referenced this pull request Jun 21, 2023
* master:
  Expand troubleshooting docs, add ESM, IAM, S3 commands (#3498)
  Fix code sample for package push (#3499)
  Google Tag Manager tracker (#3497)
  Network 2.0 documentation (#3486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants