Google Tag Manager tracker #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3497 +/- ##
===========================================
+ Coverage 35.83% 88.27% +52.43%
===========================================
Files 683 76 -607
Lines 29788 9722 -20066
Branches 4413 0 -4413
===========================================
- Hits 10675 8582 -2093
+ Misses 17945 1140 -16805
+ Partials 1168 0 -1168
Flags with carried forward coverage won't be shown. Click here to find out more. see 614 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nl0
previously approved these changes
Jun 15, 2023
nl0
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, the very simple code makes sense, because we probably don't need anything more sophisticated as done for Intercom and Mixpanel