Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include stop word lists from the Snowball project #1666

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Include stop word lists from the Snowball project #1666

merged 1 commit into from
Nov 9, 2022

Conversation

adamreichold
Copy link
Collaborator

Following the suggestion in #1651 (comment), this follows Apache Lucene by incorporating the stop word lists from the BSD-licensed Snowball project.

@fulmicoton
Copy link
Collaborator

The list in Lucene is much shorter I believe @adamreichold .
Also, can we inline the words as literals?

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline

@fulmicoton
Copy link
Collaborator

@adamreichold I still have a bunch of comments. Sorry for the multiple iterations. I hope it does not seem too arbitrary. Your energy and attention to detail is actually well appreciated! ❤️

@adamreichold
Copy link
Collaborator Author

@adamreichold I still have a bunch of comments. Sorry for the multiple iterations. I hope it does not seem too arbitrary. Your energy and attention to detail is actually well appreciated! heart

Better to take care and try to do it right than to slowly turn a FOSS project into a dumping ground for half-assed code drops. I don't mind iterating on this at all.

@fulmicoton fulmicoton merged commit a4b759d into quickwit-oss:main Nov 9, 2022
@fulmicoton
Copy link
Collaborator

Thank you!

@adamreichold adamreichold deleted the snowball-stopwords branch November 9, 2022 07:58
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants