RFC: Include MIT-licensed data from Stopwords ISO #1651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds pre-defined stop word filters for three common European languages based on the MIT-licensed data from Stopwords ISO [1]. This is put behind a non-default feature to avoid bloating the binary for users who are not interested in this while still providing batteries-included usability for those who are. [1] https://github.com/stopwords-iso
|
This list of stopwords seems way too long for search. |
Alright. Do you know a more reasonable source with compatible licensing terms? Otherwise, I'd propose that I just break out the first two general improvements to |
|
We can probably steal something from the Lucene world? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-defined stop word filters for three common European languages based on the MIT-licensed data from Stopwords ISO. This is put behind a non-default feature to avoid bloating the binary for users who are not interested in this while still providing batteries-included usability for those who are.