fix failing tests after rustc and serde update #5564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
approved these changes
Nov 25, 2024
fulmicoton
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit cbf35fa.
fulmicoton
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit cbf35fa.
fulmicoton
added a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #5563
Hash for IpAddr changed with 1.82, update tests relying on the order of Hash (consistent hashing stuff) to take that into account
serde error message changed slightly, fix that too
Hash for IpAddr is now endianness dependant, I don't think we care, we don't rely on this for correctness, only for more efficient distributed caching, and the supported targets (arm and x86) have the same endianness.
How was this PR tested?
cargo nextest run