Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty test #5563

Closed
fulmicoton opened this issue Nov 25, 2024 · 2 comments · Fixed by #5564
Closed

Faulty test #5563

fulmicoton opened this issue Nov 25, 2024 · 2 comments · Fixed by #5564
Assignees
Labels
bug Something isn't working

Comments

@fulmicoton
Copy link
Contributor

--- TRY 2 STDERR: quickwit-common rendezvous_hasher::tests::test_utils_sort_by_rendez_vous_hash ---
thread 'rendezvous_hasher::tests::test_utils_sort_by_rendez_vous_hash' panicked at quickwit-common/src/rendezvous_hasher.rs:67:9:
assertion left == right failed
left: [127.0.0.1:10000, 127.0.0.3:10000, 127.0.0.2:10000, 127.0.0.4:10000]
right: [127.0.0.1:10000, 127.0.0.2:10000, 127.0.0.3:10000, 127.0.0.4:10000]
stack backtrace:
0: rust_begin_unwind
1: core::panicking::panic_fmt
2: core::panicking::assert_failed_inner
3: core::panicking::assert_failed
4: quickwit_common::rendezvous_hasher::tests::test_utils_sort_by_rendez_vous_hash
5: quickwit_common::rendezvous_hasher::tests::test_utils_sort_by_rendez_vous_hash::{{closure}}
6: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.

@fulmicoton fulmicoton added the bug Something isn't working label Nov 25, 2024
@fulmicoton
Copy link
Contributor Author

it is not flaky. Somehow the test was broken with 6362633

@fulmicoton fulmicoton changed the title flaky test Faulty test Nov 25, 2024
@trinity-1686a trinity-1686a self-assigned this Nov 25, 2024
@trinity-1686a
Copy link
Contributor

tracked down to this change: rust-lang/rust#128946
how IP address hash themselves changed, so we need to update the expected order/hash of anything IpAddr/SocketAddr related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants