Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial work on pandoc 3.1.7 #6729

Merged
merged 4 commits into from
Sep 5, 2023
Merged

initial work on pandoc 3.1.7 #6729

merged 4 commits into from
Sep 5, 2023

Conversation

dragonstyle
Copy link
Collaborator

@dragonstyle dragonstyle commented Sep 5, 2023

Update to Pandoc 3.1.7.

Template changes were simple and safe and exposed a bug in a couple tests which were trying to set cite-method and using incorrect keys.

Pandoc behavior for hyperlinking now emits phantomsection with a label as a link target, which results in duplicate labels for equations. That is fixed in equations.lua and is something I'd appreciate a second, better informed set of eyes (@cscheid). (see jgm/pandoc#9045)

@dragonstyle dragonstyle added this to the v1.4 milestone Sep 5, 2023
@dragonstyle dragonstyle marked this pull request as ready for review September 5, 2023 19:51
Copy link
Collaborator

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there smoke-all tests we could add to check for the correct cite-method usage?

@dragonstyle
Copy link
Collaborator Author

Are there smoke-all tests we could add to check for the correct cite-method usage?

It was literally just badly written tests (the extensions and all were all correct, just the test documents themselves were invalid). Since the schema is open, I'm not sure we can do much to help the user our in this situation unless I'm missing something.

@cscheid
Copy link
Collaborator

cscheid commented Sep 5, 2023

It was literally just badly written tests

Got it.

unless I'm missing something.

Nope, I don't think you are, I just wanted to check.

@dragonstyle dragonstyle merged commit 687399e into main Sep 5, 2023
@dragonstyle dragonstyle deleted the feature/pandoc-3.1.7 branch September 5, 2023 21:11
cderv added a commit that referenced this pull request Sep 6, 2023
…ting for next Pandoc version with fix"

This reverts commit 44389a3 as now
Quarto uses Pandoc 3.1.7 (#6729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants