Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign bias tuning and power monitor read-out #92

Merged
merged 17 commits into from
Oct 13, 2020

Conversation

jordens
Copy link
Member

@jordens jordens commented Oct 9, 2020

  • Makes bias tuning reliable on all the channels I have. Moves the algorithm to the host (close Bias tuning unreliable #66)
  • Use proper asyncio sleep
  • Re-implement the power monitor read-out, close ads7924 glitches #61
  • Speed up the ads7924 api by packing read out of all channels.
  • Speed up the channel monitoring task by packing the state machine update with the channel status read out.
  • Remove the booster_channels intermediate API layer in favor of passing through the rf_channel api to closures.
  • Remove a couple unnecessary constructs (RefCell, mut x: &mut y, etc)
  • Reduce some code pattern duplication in mqtt_control
  • Fixes an issue introduced in Fixing slope for input/reflected power measurements #74 (fixes Input power measurement wrong #59)
  • Tested on a 8 channel device

NB:

  • Before this, sometimes the device would reboot at random times. Presumably watchdog. My assumption is that the speed up addresses this but we should keep an eye on this. Watchdog triggering #94
  • 2 Hz telemetry is probably a bit high. Maybe 0.1 Hz. telemetry rate #95
  • The telemetry also stalls the mqtt api noticably. Maybe let the telemetry task handle one channel per schedule. telemetry rate #95
  • Clarify that when the transforms are changed, the threshold DACs are not automatically updated. (Or change that behavior). transform setting doesn't affect thresholds #96
  • It seemed to me that while the power measurements are accurate, the thresholds are wrong (too sensitive). Need to gather some data on that. check threshold accuracy #97

@jordens jordens force-pushed the feature/redesign-bias-tuning branch from 83664a0 to 5e39b98 Compare October 9, 2020 18:41
@jordens jordens changed the title Feature/redesign bias tuning redesign bias tuning and power monitor read-out Oct 9, 2020
@jordens jordens requested a review from ryan-summers October 12, 2020 09:40
Copy link
Member

@ryan-summers ryan-summers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the changes and think they're a nice direction for the code. Would you please propagate out all of the issues you have mentioned in the original PR into various issues so we can investigate in the future?

ads7924/src/lib.rs Show resolved Hide resolved
booster.py Show resolved Hide resolved
booster.py Show resolved Hide resolved
ads7924/src/lib.rs Show resolved Hide resolved
ads7924/src/lib.rs Outdated Show resolved Hide resolved
ads7924/src/lib.rs Outdated Show resolved Hide resolved
src/booster_channels.rs Show resolved Hide resolved
src/mqtt_control.rs Show resolved Hide resolved
src/mqtt_control.rs Show resolved Hide resolved
@jordens jordens mentioned this pull request Oct 13, 2020
@jordens jordens requested a review from ryan-summers October 13, 2020 13:33
@ryan-summers ryan-summers merged commit a2cad65 into develop Oct 13, 2020
@ryan-summers ryan-summers deleted the feature/redesign-bias-tuning branch October 13, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bias tuning unreliable ads7924 glitches Input power measurement wrong
2 participants