Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transform setting doesn't affect thresholds #96

Closed
jordens opened this issue Oct 13, 2020 · 3 comments · Fixed by #170
Closed

transform setting doesn't affect thresholds #96

jordens opened this issue Oct 13, 2020 · 3 comments · Fixed by #170
Labels
enhancement New feature or request
Milestone
0.3.0

Comments

@jordens
Copy link
Member

jordens commented Oct 13, 2020

Clarify that when the transforms are changed, the threshold DACs are not automatically updated. (Or recalculate and update them).
@jordens jordens mentioned this issue Oct 13, 2020
Merged
@jordens jordens added the enhancement New feature or request label Oct 13, 2020
@ryan-summers
Copy link
Member

I think the least-surprising implementation would be to reconfigure the DACs after the transforms are updated, although I haven't looked at how complicated that would be in the code to update.

@jordens
Copy link
Member Author

jordens commented Oct 13, 2020

Agreed.

@hartytp
Copy link

hartytp commented Dec 21, 2020

aah, I think I just hit this...

@ryan-summers ryan-summers added this to the 0.3.0 milestone Dec 1, 2021
@ryan-summers ryan-summers mentioned this issue Jan 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Miniconf Support quartiq/booster
3 participants
@jordens @ryan-summers @hartytp