Improve error handling and validation for Maven resources #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update status codes for invalid requests - Remove test for inexistent platforms - Update test for platforms - Require all version numbers to be larger than 0 for validation - Fixes #183 [src/test/java/io/quarkus/registry/app/services/MavenResourceTest.java] - Change return status code from `400` to `404` for requests with invalid version - Change return status code from `400` to `404` for requests with invalid snapshot version - Change return status code from `400` to `404` for requests with invalid version in sha1 file - Change return status code from `400` to `404` for requests with invalid snapshot version in sha1 file - Remove test for inexistent platforms - Update test for [src/main/java/io/quarkus/registry/app/maven/PlatformsContentProvider.java] - Change the response status from `NO_CONTENT` to `NOT_FOUND` when no platforms are found [src/main/java/io/quarkus/registry/app/util/Version.java] - Require major, minor, and incremental versions to be larger than 0 for validation
aloubyansky
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[src/test/java/io/quarkus/registry/app/services/MavenResourceTest.java]
400to404for requests with invalid version400to404for requests with invalid snapshot version400to404for requests with invalid version in sha1 file400to404for requests with invalid snapshot version in sha1 file[src/main/java/io/quarkus/registry/app/maven/PlatformsContentProvider.java]
NO_CONTENTtoNOT_FOUNDwhen no platforms are found[src/main/java/io/quarkus/registry/app/util/Version.java]