Using an invalid version as a target Quarkus version returns 204 #183
Assignees
Comments
gastaldi
added a commit
that referenced
this issue
Mar 31, 2023
- Update status codes for invalid requests - Remove test for inexistent platforms - Update test for platforms - Require all version numbers to be larger than 0 for validation - Fixes #183 [src/test/java/io/quarkus/registry/app/services/MavenResourceTest.java] - Change return status code from `400` to `404` for requests with invalid version - Change return status code from `400` to `404` for requests with invalid snapshot version - Change return status code from `400` to `404` for requests with invalid version in sha1 file - Change return status code from `400` to `404` for requests with invalid snapshot version in sha1 file - Remove test for inexistent platforms - Update test for [src/main/java/io/quarkus/registry/app/maven/PlatformsContentProvider.java] - Change the response status from `NO_CONTENT` to `NOT_FOUND` when no platforms are found [src/main/java/io/quarkus/registry/app/util/Version.java] - Require major, minor, and incremental versions to be larger than 0 for validation
gastaldi
added a commit
that referenced
this issue
Mar 31, 2023
- Update status codes for invalid requests - Remove test for inexistent platforms - Update test for platforms - Require all version numbers to be larger than 0 for validation - Fixes #183 [src/test/java/io/quarkus/registry/app/services/MavenResourceTest.java] - Change return status code from `400` to `404` for requests with invalid version - Change return status code from `400` to `404` for requests with invalid snapshot version - Change return status code from `400` to `404` for requests with invalid version in sha1 file - Change return status code from `400` to `404` for requests with invalid snapshot version in sha1 file - Remove test for inexistent platforms - Update test for [src/main/java/io/quarkus/registry/app/maven/PlatformsContentProvider.java] - Change the response status from `NO_CONTENT` to `NOT_FOUND` when no platforms are found [src/main/java/io/quarkus/registry/app/util/Version.java] - Require major, minor, and incremental versions to be larger than 0 for validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The URL is OK. It is using 999-SNAPSHOT as a target Quarkus version. @gastaldi this looks like a registry issue, could you have a look, please?
https://registry.quarkus.io/maven/io/quarkus/registry/quarkus-platforms/1.0-SNAPSHOT/quarkus-platforms-1.0-SNAPSHOT-999-SNAPSHOT.json results in an empty file, as well as the
sha1checksum for it. It should simply return 404 in case the version isn't recognized.Originally posted by @aloubyansky in quarkusio/quarkus#32266 (comment)
The text was updated successfully, but these errors were encountered: