-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 'security' keyword to all security guides #1167
Add a 'security' keyword to all security guides #1167
Conversation
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167 * removed the web category for the security-jwt guide (Using JWT RBAC) * added the "security" keyword for the same guide Signed-off-by: Nathan Erwin <[email protected]>
♻️ PR Preview f627d0b has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
Hi @nderwin thanks for this PR - it does look better, see the PR preview link but it does not show all the guides available under |
@sberyozkin Sure, I'll add the keyword to the others, I just wasn't sure how many to add it to originally. Should the other guide YAML files have these changes applied, or should it only be applied to the |
IMHO all the guides we see under
Not sure, Guillaume, @gsmet, can you clarify please when you get a chance ? |
@nderwin please squash the commits as well |
aa813c7
to
172c65e
Compare
172c65e
to
18cf7cb
Compare
@nderwin thanks, looks good to me, the last minor problem the commit message, it reads I'd like to merge tomorrow in any case, @gsmet if you have any concerns let me know please, IMHO this update is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting till tomorrow for Guillaume to have a look
…or the JWT guide from the web category Signed-off-by: Nathan Erwin <[email protected]>
18cf7cb
to
f627d0b
Compare
@sberyozkin I updated the commit message and the PR description; how's it look now? If accepted and merged, could I persuade you to put a |
@nderwin Sure, thanks for your help |
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167 * removed the web category for the security-jwt guide (Using JWT RBAC) * added the "security" keyword for the same guide Signed-off-by: Nathan Erwin <[email protected]> (cherry picked from commit 58d4b18)
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167 * removed the web category for the security-jwt guide (Using JWT RBAC) * added the "security" keyword for the same guide Signed-off-by: Nathan Erwin <[email protected]> (cherry picked from commit 58d4b18)
Add a security keyword to all security guides, and remove listing for the JWT guide from the web category
(related to quarkusio/quarkus#20622)
Signed-off-by: Nathan Erwin [email protected]