Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'security' keyword to all security guides #1167

Merged

Conversation

nderwin
Copy link
Contributor

@nderwin nderwin commented Oct 12, 2021

Add a security keyword to all security guides, and remove listing for the JWT guide from the web category

(related to quarkusio/quarkus#20622)

Signed-off-by: Nathan Erwin [email protected]

nderwin added a commit to nderwin-forks/quarkus that referenced this pull request Oct 12, 2021
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167

* removed the web category for the security-jwt guide (Using JWT RBAC)
* added the "security" keyword for the same guide

Signed-off-by: Nathan Erwin <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 12, 2021

♻️ PR Preview f627d0b has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@sberyozkin
Copy link
Member

Hi @nderwin thanks for this PR - it does look better, see the PR preview link but it does not show all the guides available under Security category when I search for security, can you please add a security keyword to all the guides in the security category, I think the keywords should support more than one word, either as comma separated values or an array

@nderwin
Copy link
Contributor Author

nderwin commented Oct 12, 2021

@sberyozkin Sure, I'll add the keyword to the others, I just wasn't sure how many to add it to originally.

Should the other guide YAML files have these changes applied, or should it only be applied to the guides-latest.yaml file?

@sberyozkin
Copy link
Member

@nderwin

Sure, I'll add the keyword to the others, I just wasn't sure how many to add it to originally.

IMHO all the guides we see under Security category should be shown when a user who'd like to find about Quarkus Security types security, that way it will be consistent, same guides are shown whichever way one starts looking for them...

Should the other guide YAML files have these changes applied, or should it only be applied to the guides-latest.yaml file?

Not sure, Guillaume, @gsmet, can you clarify please when you get a chance ?

@sberyozkin
Copy link
Member

@nderwin please squash the commits as well

@nderwin nderwin force-pushed the feature/improve-security-search branch from aa813c7 to 172c65e Compare October 12, 2021 15:12
@sberyozkin
Copy link
Member

@nderwin I've looked at 8b0fe6d, I think the same should be done with this PR, can you please also update quarkus-main ?
Also, please update the title and commit message, may be Add a 'security' keyword to all security guides ?

@nderwin nderwin changed the title Fix for Quarkus Issue #20622 Add a 'security' keyword to all security guides Oct 13, 2021
@nderwin nderwin force-pushed the feature/improve-security-search branch from 172c65e to 18cf7cb Compare October 13, 2021 12:46
@sberyozkin
Copy link
Member

sberyozkin commented Oct 13, 2021

@nderwin thanks, looks good to me, the last minor problem the commit message, it reads removed listing for "Using JWT RBAC" from the web category which is part of this PR but it is primarily about the security keyword, it is probably OK to leave it as it is as the title reflects it, but if you don't mind then please update as well to Add a 'security' keyword to all security guides and remove listing for the JWT guide from the web category or something like that.

I'd like to merge tomorrow in any case, @gsmet if you have any concerns let me know please, IMHO this update is needed.

@sberyozkin sberyozkin self-requested a review October 13, 2021 17:09
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting till tomorrow for Guillaume to have a look

…or the JWT guide from the web category

Signed-off-by: Nathan Erwin <[email protected]>
@nderwin nderwin force-pushed the feature/improve-security-search branch from 18cf7cb to f627d0b Compare October 13, 2021 19:55
@nderwin
Copy link
Contributor Author

nderwin commented Oct 13, 2021

@sberyozkin I updated the commit message and the PR description; how's it look now?

If accepted and merged, could I persuade you to put a hacktoberfest-accepted label on the PR?

@sberyozkin sberyozkin added the hacktoberfest-accepted Fixed by Hactoberfest contributors label Oct 14, 2021
@sberyozkin
Copy link
Member

@nderwin Sure, thanks for your help

@sberyozkin sberyozkin merged commit 34bcc9f into quarkusio:develop Oct 14, 2021
@nderwin nderwin deleted the feature/improve-security-search branch October 14, 2021 13:13
aloubyansky pushed a commit to aloubyansky/quarkus that referenced this pull request Oct 18, 2021
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167

* removed the web category for the security-jwt guide (Using JWT RBAC)
* added the "security" keyword for the same guide

Signed-off-by: Nathan Erwin <[email protected]>
(cherry picked from commit 58d4b18)
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Oct 18, 2021
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167

* removed the web category for the security-jwt guide (Using JWT RBAC)
* added the "security" keyword for the same guide

Signed-off-by: Nathan Erwin <[email protected]>
(cherry picked from commit 58d4b18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Fixed by Hactoberfest contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants