Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Security Search Experience in Quarkus Guides #20622

Closed
sberyozkin opened this issue Oct 8, 2021 · 1 comment
Closed

Improve Security Search Experience in Quarkus Guides #20622

sberyozkin opened this issue Oct 8, 2021 · 1 comment
Labels
area/documentation area/security good first issue Good for newcomers
Milestone
2.5.0.CR1

Comments

@sberyozkin
Copy link
Member

Description

Typing security in the Quarkus guides search box finds 5 Security guides (Security Overview and 4 identity provider guides - Properties, Ldap, Jpa and Jdbc), one Compatibility guide, Spring Security is also found. No other guides are visible.

Curiously, if one starts typing security, and reaches secur, 3 more guides become visible, OAuth2, JWT, Vault but after progressing to securi they disappear.

Also, JWT RBAC should be removed from the Web category, it is currently visible in Web and Security

Implementation ideas

Looks like all of the extensions related to security should have a security metadata tag added.
@sberyozkin sberyozkin added area/documentation area/security area/housekeeping Issue type for generalized tasks not related to bugs or enhancements labels Oct 8, 2021
@sberyozkin sberyozkin mentioned this issue Oct 8, 2021
Open
9 tasks
@sberyozkin sberyozkin added the good first issue Good for newcomers label Oct 8, 2021
nderwin added a commit to nderwin-forks/quarkusio.github.io that referenced this issue Oct 12, 2021
@nderwin
Fix for Quarkus Issue #20622
b865a70 
Related to quarkusio/quarkus#20622

* removed listing for "Using JWT RBAC" from the web category
* added security keywords to entries in the security category so the search feature will continue to find them for partially complete "security" search terms

Signed-off-by: Nathan Erwin <[email protected]>
@nderwin nderwin mentioned this issue Oct 12, 2021
Merged
nderwin added a commit to nderwin-forks/quarkus that referenced this issue Oct 12, 2021
@nderwin
Fix for quarkusio#20622
58d4b18 
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167

* removed the web category for the security-jwt guide (Using JWT RBAC)
* added the "security" keyword for the same guide

Signed-off-by: Nathan Erwin <[email protected]>
@nderwin nderwin mentioned this issue Oct 12, 2021
Merged
nderwin added a commit to nderwin-forks/quarkusio.github.io that referenced this issue Oct 12, 2021
@nderwin
Fix for Quarkus Issue #20622
172c65e 
Related to quarkusio/quarkus#20622

* removed listing for "Using JWT RBAC" from the web category
* added security keywords to entries in the security category so the search feature will continue to find them for partially complete "security" search terms

Signed-off-by: Nathan Erwin <[email protected]>
nderwin added a commit to nderwin-forks/quarkusio.github.io that referenced this issue Oct 13, 2021
@nderwin
* removed listing for "Using JWT RBAC" from the web category
18cf7cb 
* added security keywords to entries in the security category so the search feature will continue to find them for partially complete "security" search terms
* related to quarkusio/quarkus#20622

Signed-off-by: Nathan Erwin <[email protected]>
@sberyozkin sberyozkin added hacktoberfest-accepted Fixed by Hactoberfest contributors and removed area/housekeeping Issue type for generalized tasks not related to bugs or enhancements labels Oct 14, 2021
@sberyozkin sberyozkin added this to the 2.5 - main milestone Oct 14, 2021
@sberyozkin
Copy link
Member Author

See also #20680

@sberyozkin sberyozkin removed the hacktoberfest-accepted Fixed by Hactoberfest contributors label Oct 14, 2021
aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Oct 18, 2021
@nderwin @aloubyansky
Fix for quarkusio#20622
75902f4 
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167

* removed the web category for the security-jwt guide (Using JWT RBAC)
* added the "security" keyword for the same guide

Signed-off-by: Nathan Erwin <[email protected]>
(cherry picked from commit 58d4b18)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 18, 2021
@nderwin @gsmet
Fix for quarkusio#20622
45bdeb2 
Related to quarkusio#20622 and quarkusio/quarkusio.github.io#1167

* removed the web category for the security-jwt guide (Using JWT RBAC)
* added the "security" keyword for the same guide

Signed-off-by: Nathan Erwin <[email protected]>
(cherry picked from commit 58d4b18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation area/security good first issue Good for newcomers
Projects
None yet
Milestone
2.5.0.CR1
Development

No branches or pull requests
1 participant
@sberyozkin