-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension Info - Expose other information about Java and Git #45129
Conversation
Thanks a lot for this! Can you please simplify some of the git commits? |
What do you mean by simplifying some commits? |
There are too many of them honestly. Some of them can be be squashed |
e27aaee
to
481d28a
Compare
I squashed some commits. Is this OK? |
Great, thanks! |
Mind rebasing onto |
This PR is from Sunday and was aligned with main. Today it is certainly not aligned with main. Do you want me to rebase it to align with the latest commit of main? Commit [a717b30] a717b30) is also here because it was rolled back from PR #45123. In theory, it should not create a problem, but if it does, I will delete it. |
- added the method vendor - added the method vendorVersion - review the InfoRecorder - review the UnitTest
481d28a
to
b7ad29c
Compare
@geoand now everything is aligned and clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Status for workflow
|
The following changes are present in this PR.
Below is an example of what DevUI Info looks like now.
Below is an example of how to get the beans from the quarkus-info extension
Listing 1 - Example of how to get the beans of the quarkus-info extension