Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Info - Expose other information about Java and Git #45129

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

amusarra
Copy link
Contributor

@amusarra amusarra commented Dec 14, 2024

The following changes are present in this PR.

  • Added the RemoteURL on the DevUI Info Git card
  • Added the Application Name on the DevUI Info Build card.
  • Added the Quarkus Version on the DevUI Info Build card.
  • Added the JavaDoc on the JavaInfo interface.
  • Extended the DevUI Info JavaInfo card with the new info.
  • Extension of the JavaInfo interface
  • Fixed the assign value to the latestCommitTime (see the PR Extension info - Fixed the assign value to the latestCommitTime #45123)

Below is an example of what DevUI Info looks like now.

image

Below is an example of how to get the beans from the quarkus-info extension

//...
import io.quarkus.info.BuildInfo;
import io.quarkus.info.GitInfo;
import io.quarkus.info.JavaInfo;
import io.quarkus.info.OsInfo;

@Path("/whoami")
public class WhoAmIResource {
    @Inject
    GitInfo gitInfo;

    @Inject
    BuildInfo buildInfo;

    @Inject
    JavaInfo javaInfo;

    @Inject
    OsInfo osInfo;
    
    // Use the inject bean
   //....
}    

Listing 1 - Example of how to get the beans of the quarkus-info extension

@geoand
Copy link
Contributor

geoand commented Dec 16, 2024

Thanks a lot for this!

Can you please simplify some of the git commits?

@amusarra
Copy link
Contributor Author

amusarra commented Dec 16, 2024

Thanks a lot for this!

Can you please simplify some of the git commits?

What do you mean by simplifying some commits?

@geoand
Copy link
Contributor

geoand commented Dec 16, 2024

There are too many of them honestly. Some of them can be be squashed

@amusarra
Copy link
Contributor Author

There are too many of them honestly. Some of them can be be squashed

I squashed some commits. Is this OK?

@geoand
Copy link
Contributor

geoand commented Dec 16, 2024

Great, thanks!

@geoand
Copy link
Contributor

geoand commented Dec 16, 2024

Mind rebasing onto main as we merged #45123?

@amusarra
Copy link
Contributor Author

amusarra commented Dec 16, 2024

Mind rebasing onto main as we merged #45123?

This PR is from Sunday and was aligned with main. Today it is certainly not aligned with main. Do you want me to rebase it to align with the latest commit of main?

Commit [a717b30] a717b30) is also here because it was rolled back from PR #45123. In theory, it should not create a problem, but if it does, I will delete it.

- added the method vendor
- added the method vendorVersion
- review the InfoRecorder
- review the UnitTest
@amusarra
Copy link
Contributor Author

@geoand now everything is aligned and clean.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

quarkus-bot bot commented Dec 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b7ad29c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit e0e74f1 into quarkusio:main Dec 16, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants