Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension info - Fixed the assign value to the latestCommitTime #45123

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

amusarra
Copy link
Contributor

Replaced the method Instant.ofEpochMilli() with the method Instant.ofEpochSecond() because RevCommit.getCommitTime() return the number of the seconds from epoch.

Before the fix:
image

After fix:
image

Copy link

quarkus-bot bot commented Dec 13, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@amusarra amusarra changed the title [quarkus-ext-info] - Fixed the assign value to the latestCommitTime Quarkus-ext-info - Fixed the assign value to the latestCommitTime Dec 13, 2024
@amusarra amusarra changed the title Quarkus-ext-info - Fixed the assign value to the latestCommitTime Extension-info - Fixed the assign value to the latestCommitTime Dec 14, 2024
@amusarra amusarra changed the title Extension-info - Fixed the assign value to the latestCommitTime Extension info - Fixed the assign value to the latestCommitTime Dec 14, 2024
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 16, 2024

This comment has been minimized.

Replaced the method Instant.ofEpochMilli() with the method
Instant.ofEpochSecond() because RevCommit.getCommitTime()
return the number of the seconds from epoch.
@gsmet gsmet force-pushed the fix/ext-info-git-time-commit branch from af8c56b to 796c92a Compare December 16, 2024 10:39
@gsmet
Copy link
Member

gsmet commented Dec 16, 2024

I rebased to drop the merge commit.

You typically don't need to rebase except if there is a conflict and we ask for it.
If you do the pull.rebase option might be handy: https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#before-you-contribute

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot for all these improvements.

Copy link

quarkus-bot bot commented Dec 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 796c92a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 0997246 into quarkusio:main Dec 16, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 16, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants