Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keycloak Dev service to allocate default client id and secret #42947

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix Keycloak Dev service to allocate default client id and secret #42947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...in/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,16 +853,14 @@ private static String getOidcApplicationType() {
}

private static String getOidcClientId() {
boolean isService = "service".equals(getOidcApplicationType());
// if the application type is web-app or hybrid, OidcRecorder will enforce that the client id and secret are configured
return ConfigProvider.getConfig().getOptionalValue(CLIENT_ID_CONFIG_KEY, String.class)
.orElse(!isService ? "quarkus-app" : "");
.orElse(capturedDevServicesConfiguration.createClient ? "quarkus-app" : "");
}

private static String getOidcClientSecret() {
boolean isService = "service".equals(getOidcApplicationType());
// if the application type is web-app or hybrid, OidcRecorder will enforce that the client id and secret are configured
return ConfigProvider.getConfig().getOptionalValue(CLIENT_SECRET_CONFIG_KEY, String.class)
.orElse(!isService ? "secret" : "");
.orElse(capturedDevServicesConfiguration.createClient ? "secret" : "");
}
}