Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keycloak Dev service to allocate default client id and secret #42947

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Sep 2, 2024

This PR fixes a bug I introduced with the OIDC dynamic client registration PR where for some reasons I decided not to return a default client id and secret for service applications when devservice is used, I was adding tests involving an OIDC web-app where I did not want the client created because it was dynamically registered, but I honestly don't remember why I coded it that way. It was not caught earlier because it does look like all the tests depending on the KC devservice already have a client id configured for service applications...

The logic is that the client id and secret should not be registered as OIDC properties if no client is expected to be created but the allocation is wrong, it should be an empty value only if no client creation is allowed.

Spotted at #42935.

It is a main branch issue only, so no regressions for the released versions.

@michalvavrik Please pick up this update once it is merged, thanks

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

quarkus-bot bot commented Sep 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f37e1b6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit dcd9928 into quarkusio:main Sep 2, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 2, 2024
@sberyozkin sberyozkin deleted the fix_oidc_devservice_oidc_client_allocation branch September 2, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants