Fix Keycloak Dev service to allocate default client id and secret #42947
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug I introduced with the OIDC dynamic client registration PR where for some reasons I decided not to return a default client id and secret for
service
applications when devservice is used, I was adding tests involving an OIDC web-app where I did not want the client created because it was dynamically registered, but I honestly don't remember why I coded it that way. It was not caught earlier because it does look like all the tests depending on the KC devservice already have a client id configured for service applications...The logic is that the client id and secret should not be registered as OIDC properties if no client is expected to be created but the allocation is wrong, it should be an empty value only if no client creation is allowed.
Spotted at #42935.
It is a
main
branch issue only, so no regressions for the released versions.@michalvavrik Please pick up this update once it is merged, thanks