Update to Vertx 4.5.1 #38034

cescoffier · 2024-01-04T14:22:48Z

Update to Vert.x 4.5.1 and Netty 4.1.103.Final

Known limitations: AWS Lambdas implemented using Servlets are not working anymore. It needs to be investigated.

\CC @Sanne

gsmet

I asked a couple of questions.

integration-tests/oidc/src/main/java/io/quarkus/it/keycloak/VertxResource.java

gsmet · 2024-01-04T18:27:16Z

...n-tests/oidc/src/test/java/io/quarkus/it/keycloak/KeycloakXTestResourceLifecycleManager.java

@@ -29,7 +29,7 @@ public class KeycloakXTestResourceLifecycleManager implements QuarkusTestResourc
    private static String KEYCLOAK_SERVER_URL;
    private static final String KEYCLOAK_REALM = "quarkus";
    private static final String KEYCLOAK_SERVICE_CLIENT = "quarkus-service-app";
-    private static final String KEYCLOAK_VERSION = System.getProperty("keycloak.version");
+    private static final String KEYCLOAK_VERSION = System.getProperty("keycloak.version", "23.0.1");


I'm not sure how this property was supposed to be passed before? @sberyozkin ?

Without you cannot run the tests from the IDE. It super inconvenient when you need to debug dozens of tests.

I can revert that change, but you can be sure I will redo the same next time I need to debug these tests.

gsmet · 2024-01-04T18:28:29Z

...azon-lambda-rest/src/test/java/io/quarkus/it/amazon/lambda/AmazonLambdaV1SimpleTestCase.java

+    @Test
+    @Disabled("Does not work with Vert.x 4.5.1 - to be investigated")
+    public void testPostTextWithServlet() throws Exception {
+        testPostTextByEvent("/servlet/hello");
+        testPostText("/servlet/hello");
+    }


What's the plan for these?

Well, the plan is to dive into the depth of undertow and try to understand why the handler is not called anymore. It only happens when used with the virtual server, which I hope to remove at some point (as it breaks every single time).

I already tried to debug it without luck and we need to make progress to meet the deadline.

Agreed, thanks for the details.

...y-http/runtime/src/main/java/io/quarkus/funqy/runtime/bindings/http/VertxRequestHandler.java

gsmet · 2024-01-04T18:31:13Z

Also, great work :).

gsmet · 2024-01-05T09:20:22Z

...eactive/client/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/ClientImpl.java

-import io.vertx.core.Vertx;
-import io.vertx.core.VertxOptions;
-import io.vertx.core.WorkerExecutor;
+import io.vertx.core.*;


Sorry I missed that but we don't want star imports.

gsmet

LGTM except for the star imports. Sorry for noticing them so late.

gsmet

I got rid of the star imports, rebased and force pushed.

Let's wait for CI and merge.

geoand · 2024-01-05T15:34:37Z

Ah darn, there is now a conflict in the bom :(

gsmet · 2024-01-05T15:37:45Z

I'll fix it once I'm done with my current task.

This class has been removed. The worker context class has also been removed (used in test). We now use the ContextInternal class.

The createMessage method signature changed.

…n handler. As the body may have already been read.

…a context after the application shutdown.

It avoids a race condition when reading the body

This version contains the API for Vert.x 4.5.1. Note that there is a few change in the Redis low level API. These changes are backward compatible.

This version has been built with Vert.x 4.5.1 and Netty 4.1.103.Final.

This version is using Vert.x 4.5.1 and the Mutiny bindings 3.8.0

This is the version required to work with Vert.x 4.5.1 (due to the API changes in this Vert.x release)

It avoids a potential race condition trying to read the body twice.

When using Undertow, the request body is not read correctly. Something is wrong between Undertow, Quarkus HTTP and the virtual server.

gsmet · 2024-01-05T16:00:18Z

Done!

quarkus-bot · 2024-01-05T20:27:26Z

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

quarkus-bot bot added area/amazon-lambda area/dependencies Pull requests that update a dependency file area/funqy area/grpc gRPC area/oidc area/redis area/vertx labels Jan 4, 2024

This comment has been minimized.

Sign in to view

gsmet reviewed Jan 4, 2024

View reviewed changes

cescoffier force-pushed the vertx-4.5.1 branch from d551c08 to 8318cf5 Compare January 5, 2024 09:02

gsmet reviewed Jan 5, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

gsmet force-pushed the vertx-4.5.1 branch from 8318cf5 to eb16730 Compare January 5, 2024 13:45

gsmet approved these changes Jan 5, 2024

View reviewed changes

gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 5, 2024

jdussouillez mentioned this pull request Jan 5, 2024

Update vertx to 4.5.1 #37864

Closed

cescoffier added 10 commits January 5, 2024 16:58

Update dependency version to Vert.x 4.5.1 and Netty 4.1.103.Final

f3e7d54

Remove usage of the EventLoopContext

356bf86

This class has been removed. The worker context class has also been removed (used in test). We now use the ContextInternal class.

Fix ClusteredEventBus substitution

9be71ae

The createMessage method signature changed.

RESTEasy Reactive - Migrate to Vert.x 4.5.1

df01080

Funqy - Read the body using the Vert.x body handler instead of its ow…

e2ae818

…n handler. As the body may have already been read.

gRPC - Ignore rejected operation exception when scheduling a task on …

c02f381

…a context after the application shutdown.

OIDC - Avoid reading the body directly, and use the body handler instead

fd290ff

It avoids a race condition when reading the body

Update Vert.x Mutiny Bindings to version 3.8.0

5cd8ff0

This version contains the API for Vert.x 4.5.1. Note that there is a few change in the Redis low level API. These changes are backward compatible.

Update Quarkus HTTP to 5.1.0.Final

2dc6945

This version has been built with Vert.x 4.5.1 and Netty 4.1.103.Final.

Update SmallRye Stork to version 2.5.0

f818a6b

This version is using Vert.x 4.5.1 and the Mutiny bindings 3.8.0

cescoffier added 3 commits January 5, 2024 16:59

Update SmallRye Reactive Messaging to version 4.14.0

1e28b4e

This is the version required to work with Vert.x 4.5.1 (due to the API changes in this Vert.x release)

KNative - Use the body handler to read the request body

fe4c7ae

It avoids a potential race condition trying to read the body twice.

Amazon Lambda - Disable Servlet tests when using POST

e189b59

When using Undertow, the request body is not read correctly. Something is wrong between Undertow, Quarkus HTTP and the virtual server.

gsmet force-pushed the vertx-4.5.1 branch from eb16730 to e189b59 Compare January 5, 2024 15:59

gsmet merged commit 76db2af into quarkusio:main Jan 5, 2024
50 checks passed

quarkus-bot bot added this to the 3.7 - main milestone Jan 5, 2024

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 5, 2024

jerboaa mentioned this pull request Jan 8, 2024

[GraalVM 24.0] quarkus-integration-test-hibernate-reactive-postgresql fails to compile due to vertx-sql-client issue with JDK 22 #37208

Closed

cescoffier deleted the vertx-4.5.1 branch January 15, 2024 12:47

Ladicek mentioned this pull request Feb 22, 2024

Redis cluster doesn't reconnect when node returns online #37348

Closed

jedla97 mentioned this pull request May 16, 2024

Fungy knative events GET request throws NPE #40676

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Vertx 4.5.1 #38034

Update to Vertx 4.5.1 #38034

cescoffier commented Jan 4, 2024

This comment has been minimized.

gsmet left a comment

gsmet Jan 4, 2024

cescoffier Jan 4, 2024

gsmet Jan 4, 2024

cescoffier Jan 4, 2024

gsmet Jan 4, 2024

gsmet commented Jan 4, 2024

gsmet Jan 5, 2024

gsmet left a comment

This comment has been minimized.

gsmet left a comment

geoand commented Jan 5, 2024

gsmet commented Jan 5, 2024

gsmet commented Jan 5, 2024

quarkus-bot bot commented Jan 5, 2024 •

edited by github-actions bot

Loading

Update to Vertx 4.5.1 #38034

Update to Vertx 4.5.1 #38034

Conversation

cescoffier commented Jan 4, 2024

This comment has been minimized.

gsmet left a comment

Choose a reason for hiding this comment

gsmet Jan 4, 2024

Choose a reason for hiding this comment

cescoffier Jan 4, 2024

Choose a reason for hiding this comment

gsmet Jan 4, 2024

Choose a reason for hiding this comment

cescoffier Jan 4, 2024

Choose a reason for hiding this comment

gsmet Jan 4, 2024

Choose a reason for hiding this comment

gsmet commented Jan 4, 2024

gsmet Jan 5, 2024

Choose a reason for hiding this comment

gsmet left a comment

Choose a reason for hiding this comment

This comment has been minimized.

gsmet left a comment

Choose a reason for hiding this comment

geoand commented Jan 5, 2024

gsmet commented Jan 5, 2024

gsmet commented Jan 5, 2024

quarkus-bot bot commented Jan 5, 2024 • edited by github-actions bot Loading

quarkus-bot bot commented Jan 5, 2024 •

edited by github-actions bot

Loading