Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vertx to 4.5.1 #37864

Closed

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Dec 20, 2023

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation area/grpc gRPC area/vertx labels Dec 20, 2023
@jdussouillez
Copy link

Will also close #36691 (eclipse-vertx/vertx-grpc#83)

Copy link

github-actions bot commented Dec 20, 2023

🙈 The PR is closed and the preview is expired.

@zakkak zakkak force-pushed the 2023-12-20-bump-vertx-sql-version branch from 396f259 to 7e00564 Compare December 20, 2023 12:02
@geoand
Copy link
Contributor

geoand commented Dec 20, 2023

The Vertx upgrades is something that @cescoffier handles as it requires extreme caution, knowledge of both Quarkus and Vertx internals and the broader reactive dependencies impact.

I'll let him decide, but I'm pretty sure we're going to close this one

@cescoffier
Copy link
Member

This version of vertx contains breaking changes and typically break reactive messaging, Quarkus http and the rest client. I will take care of this in January.

@geoand geoand closed this Dec 20, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Dec 20, 2023
@cescoffier
Copy link
Member

You also need to bump Netty at the same time.

@zakkak
Copy link
Contributor Author

zakkak commented Dec 20, 2023

This version of vertx contains breaking changes and typically break reactive messaging, Quarkus http and the rest client. I will take care of this in January.

You also need to bump Netty at the same time.

Good, thanks for the info @cescoffier. Please let me know if there is any way I can help as it's causing quite some noise in our CI runs with Mandrel 24.0-dev.

@cescoffier
Copy link
Member

It would be interesting to just bump Netty in a PR to see how it goes (without Vert.x)

@jdussouillez
Copy link

@zakkak FYI it was done here: #38034

@zakkak
Copy link
Contributor Author

zakkak commented Jan 8, 2024

Thanks for the heads up @jdussouillez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/grpc gRPC area/vertx triage/invalid This doesn't seem right
Projects
4 participants