ArC: improve description of injection points that are parameters #37998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
approved these changes
Jan 3, 2024
mkouba
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
The improvement is twofold: - it highlights that the injection point is a parameter by putting the parameter name at the beginning instead of the end; - it uses the word "constructor" explicitly in case the parameter belongs to a constructor.
|
Turns out |
Ladicek
force-pushed
the
improve-injection-point-target-info
branch
from
a1801ee to
2401bd6
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvement is twofold:
Resolves #37923