ArC: improve description of injection points that are parameters

The improvement is twofold: - it highlights that the injection point is a parameter by putting the parameter name at the beginning instead of the end; - it uses the word "constructor" explicitly in case the parameter belongs to a constructor.
quarkusio · Jan 3, 2024 · 2401bd6 · 2401bd6
1 parent 72b3808
commit 2401bd6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.../qute/deployment/src/test/java/io/quarkus/qute/deployment/inject/InjectionFailedTest.java b/.../qute/deployment/src/test/java/io/quarkus/qute/deployment/inject/InjectionFailedTest.java
@@ -37,7 +37,7 @@ public class InjectionFailedTest {
                     assertTrue(s.getMessage().contains(
                             "No template found for path [foo] defined at io.quarkus.qute.deployment.inject.InjectionFailedTest#foo")
                             || s.getMessage().contains(
-                                    "No template found for path [alpha] defined at io.quarkus.qute.deployment.inject.InjectionFailedTest$Client()"),
+                                    "No template found for path [alpha] defined at parameter 'alpha' of io.quarkus.qute.deployment.inject.InjectionFailedTest$Client constructor"),
                             s.getMessage());
                 }
             });

diff --git a/...ent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointInfo.java b/...ent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointInfo.java
@@ -292,11 +292,11 @@ public String getTargetInfo() {
                 }
                 String method = target.asMethod().name();
                 if (method.equals(Methods.INIT)) {
-                    method = "";
+                    method = " constructor";
                 } else {
-                    method = "#" + method;
+                    method = "#" + method + "()";
                 }
-                return target.asMethod().declaringClass().name() + method + "()" + ":" + param;
+                return "parameter '" + param + "' of " + target.asMethod().declaringClass().name() + method;
             default:
                 return target.toString();
         }

diff --git a/...java/io/quarkus/arc/test/injection/illegal/TypeVariableInitializerInjectionPointTest.java b/...java/io/quarkus/arc/test/injection/illegal/TypeVariableInitializerInjectionPointTest.java
@@ -24,7 +24,7 @@ public void testError() {
         assertNotNull(failure);
         assertTrue(failure instanceof DefinitionException);
         assertEquals(
-                "Type variable is not a legal injection point type: io.quarkus.arc.test.injection.illegal.TypeVariableInitializerInjectionPointTest$Head#setIt():it",
+                "Type variable is not a legal injection point type: parameter 'it' of io.quarkus.arc.test.injection.illegal.TypeVariableInitializerInjectionPointTest$Head#setIt()",
                 failure.getMessage());
     }