Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Fix vale errors and some warnings in the "OpenID Connect (OIDC) and O… #37079

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 14, 2023

…Auth2 Client and Filters Reference Guide"

Manually cherry-picked 420fca3 from #37020 in main' to the 3.2branch. While fixing the merge conflict, I excluded the new section inmain, [GraphQL client integration](https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/security-openid-connect-client-reference.adoc#graphql-client-integration) from this 3.2` PR.

FYI @aloubyansky

Copy link

quarkus-bot bot commented Nov 14, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)
  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Nov 14, 2023
Copy link

github-actions bot commented Nov 14, 2023

🙈 The PR is closed and the preview is expired.

@rolfedh rolfedh requested a review from sberyozkin November 14, 2023 15:01
@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 14, 2023

@sberyozkin Rather than shorten the title of this PR, I matched the title of the PR in main. I did this because some teams prefer that the two titles (main/3.2 in this case) match each other. Not sure what the preference of this team is.

@aloubyansky aloubyansky merged commit 3929697 into quarkusio:3.2 Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

3 participants