-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vale errors and warnings in the OpenID Connect (OIDC) and OAuth2 Client and Filters Reference Guide #37020
Fix vale errors and warnings in the OpenID Connect (OIDC) and OAuth2 Client and Filters Reference Guide #37020
Conversation
…Auth2 Client and Filters Reference Guide"
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
🙈 The PR is closed and the preview is expired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rolfedh.
FYI, to avoid PR titles be stripped of some trailing words and the bot be unhappy the titles should be quite short, and indeed, the description can expand it, so I tried to shorten the title a bit, thanks 👍
Thanks. I didn't realize this was an issue for our tooling. In the future, I'll use short titles and rely on the description to provide fuller information. |
Not backporting to 3.5 as doesn't apply cleanly. I will let @aloubyansky judge if he wants to backport that to 3.2 (I removed the label and then readded as it's not my call). |
@rolfedh - Removing backport label as this guide is not being published for the 3.2 product doc release. Thanks. |
@sberyozkin This is a quality update for
main
.Do you approve backporting it to
3.2
as well?Note: Here, I've made minimal changes to fix Vale errors and some warnings.
Related to QDOCS-536.