Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vale errors and warnings in the OpenID Connect (OIDC) and OAuth2 Client and Filters Reference Guide #37020

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 10, 2023

@sberyozkin This is a quality update for main.
Do you approve backporting it to 3.2 as well?

Note: Here, I've made minimal changes to fix Vale errors and some warnings.
Related to QDOCS-536.

Copy link

quarkus-bot bot commented Nov 10, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

Copy link

github-actions bot commented Nov 10, 2023

🙈 The PR is closed and the preview is expired.

@sberyozkin sberyozkin changed the title Fix vale errors and some warnings in the "OpenID Connect (OIDC) and O… Fix vale errors and warnings in the OpenID Connect (OIDC) and OAuth2 Client and Filters Reference Guide Nov 10, 2023
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rolfedh.

FYI, to avoid PR titles be stripped of some trailing words and the bot be unhappy the titles should be quite short, and indeed, the description can expand it, so I tried to shorten the title a bit, thanks 👍

@sberyozkin sberyozkin merged commit a706722 into quarkusio:main Nov 10, 2023
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 10, 2023
@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 13, 2023

the titles should be quite short

Thanks. I didn't realize this was an issue for our tooling. In the future, I'll use short titles and rely on the description to provide fuller information.

@gsmet
Copy link
Member

gsmet commented Nov 13, 2023

Not backporting to 3.5 as doesn't apply cleanly. I will let @aloubyansky judge if he wants to backport that to 3.2 (I removed the label and then readded as it's not my call).

@michelle-purcell
Copy link
Contributor

@rolfedh - Removing backport label as this guide is not being published for the 3.2 product doc release. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

4 participants