Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gRPC Protoc to version 3.24.4 and the generator to 1.59.0 #36627

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Update gRPC Protoc to version 3.24.4 and the generator to 1.59.0 #36627

merged 1 commit into from
Oct 24, 2023

Conversation

cescoffier
Copy link
Member

  • Add move architecture to cover ppcle64 and s390x
  • Update code to handle deprecations and removed API

Fix #22418

@cescoffier cescoffier requested a review from alesj October 23, 2023 09:29
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/grpc gRPC labels Oct 23, 2023
alesj
alesj reviewed Oct 23, 2023
View reviewed changes
extensions/grpc/inprocess/pom.xml
@@ -17,5 +17,9 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-grpc</artifactId>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-inprocess</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They extracted this into new / diff jar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes…

@cescoffier
Update gRPC Protoc to version 3.24.4 and the generator to 1.59.0
6ffb578 
- Add move architecture to cover ppcle64 and s390x
- Update code to handle deprecation and removed API
@cescoffier cescoffier force-pushed the grpc-update=and-arch branch from 93a9414 to 6ffb578 Compare October 23, 2023 11:23
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

Failing Jobs - Building 6ffb578

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✖ JVM Tests - JDK 20 Build ⚠️ Check → Logs Raw logs
✔️ Maven Tests - JDK 11
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
✖ Native Tests - Messaging1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 364 more

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.http2.Http2RSTFloodProtectionTest.testRstFloodProtection line 67 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: RST flood protection failed
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
	at org.junit.jupiter.api.Assertions.fail(Assertions.java:134)

✖ io.quarkus.vertx.http.proxy.TrustedForwarderProxyFailureTest.testHeadersAreIgnored line 29 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/kafka-oauth-keycloak

📦 integration-tests/kafka-oauth-keycloak

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-kafka-oauth-keycloak: Failed to build quarkus application

@cescoffier cescoffier requested a review from geoand October 24, 2023 06:17
@gsmet gsmet merged commit 8de2d22 into quarkusio:main Oct 24, 2023
47 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 24, 2023
@cescoffier cescoffier deleted the grpc-update=and-arch branch October 25, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@alesj alesj alesj approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/grpc gRPC
Projects
None yet
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.

add protoc ppc64le to grpc codegen
4 participants
@cescoffier @alesj @geoand @gsmet