Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add protoc ppc64le to grpc codegen #22418

Closed
michalszynkiewicz opened this issue Dec 20, 2021 · 7 comments · Fixed by #36627
Closed

add protoc ppc64le to grpc codegen #22418

michalszynkiewicz opened this issue Dec 20, 2021 · 7 comments · Fixed by #36627
Assignees
Labels
area/grpc gRPC area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone

Comments

@michalszynkiewicz
Copy link
Member

Description

At the moment an attempt to build Quarkus on ppc64le fails with Failed to find com.google.protobuf:protoc:linux-ppc64le:exe among dependencies.
We should fix it by adding the aforementioned artifact to codegen dependencies

Implementation ideas

No response

@michalszynkiewicz michalszynkiewicz added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Dec 20, 2021
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Dec 20, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 20, 2021

/cc @cescoffier

@michalszynkiewicz
Copy link
Member Author

After more investigation:

  • even though the protoc artifact is available for the given architecture, another artifact io.grpc:protoc-gen-grpc-java is not
  • this, unfortunately means that we cannot make it work on ppc64le
  • please note that this only affects building Quarkus apps on the given architecutre and not running them

@michalszynkiewicz
Copy link
Member Author

@cescoffier I don't know how big powerpc is nowadays but the above is another argument for java-based solution for generating stubs :)

@jamesnetherton
Copy link
Contributor

@cescoffier Do you think this could be implemented? Seems there is a ppc64le variant of io.grpc:protoc-gen-grpc-java available now:

https://repo1.maven.org/maven2/io/grpc/protoc-gen-grpc-java/1.58.0/

@cescoffier
Copy link
Member

I would need to be able to test it, and I do not have access to that kind of machine.

@shreyakajbaje
Copy link

shreyakajbaje commented Oct 19, 2023

Hi @cescoffier and @jamesnetherton , getting a ppc64le node/vm can be done via a opensource community based VM request form - https://osuosl.org/services/powerdev/request_hosting/ . Please put in Gerrit Huizenga as the IBM Advocate while filling up the form... Please let me know if this works to get access to a debugging instance.cc @gerrith3 @ghatwala

I would need to be able to test it, and I do not have access to that kind of machine.

@gerrith3
Copy link

Hey @cescoffier @jamesnetherton access should be no issue at all. The form that @shreyakajbaje included above will file a ticket and send emails to a few folks, but we've put this on what should be the fast-approval track. Let us know if you need any help or have any questions. This access is available to any open source developer needing to port or test on Power hardware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants