Adopt --strict-image-heap that will land in GraalVM for JDK 21 #35902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerboaa
approved these changes
Sep 13, 2023
|
The CI gives: in some cases. Needs further investigation. Update: Can't reproduce locally, I will reschedule a CI run https://github.com/graalvm/mandrel/actions/runs/6185102310. Update2: the issue persists on the CI |
|
@zakkak I suggest to debug this in CI with a patch like this (in order to see the |
|
CI run using mandrel built based on https://github.com/zakkak/mandrel/tree/2023-09-14-mandrel23.1-debug which includes the suggested debug patch: https://github.com/graalvm/mandrel/actions/runs/6189859027 Update 1The output states that Update 2The issue is related to using local GraalVM artifacts. I am able to reproduce locally with: Specifically, the issue is caused by the following option: Update 3The issue is actually fixed in |
oracle/graal#7393 adds a new --strict-image-heap option, that will eventually become the new default. Quarkus should start using the option with GraalVM for JDK 21 (23.1.0) to be able to test it before it becomes the new default. Closes quarkusio#35901
zakkak
force-pushed
the
2023-09-13-fix-35901
branch
from
90d57b2 to
59939ce
Compare
zakkak
added
the
triage/waiting-for-ci
|
New workflow testing with Mandrel 23.1 https://github.com/graalvm/mandrel/actions/runs/6194909863 CI is now happy. |
Failing Jobs - Building 59939ce
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx/deployment
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 379 more📦 extensions/vertx/deployment✖ ✖ ⚙️ JVM Tests - JDK 20 #- Failing: extensions/hibernate-orm/deployment
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 93 more📦 extensions/hibernate-orm/deployment✖ |
jerboaa
approved these changes
Sep 15, 2023
|
Quarkus CI failures are irrelevant. |
zakkak
added
area/native-image
and removed
triage/waiting-for-ci
geoand
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oracle/graal#7393 adds a new --strict-image-heap option, that will eventually become the new default. Quarkus should start using the option with GraalVM for JDK 21 (23.1.0) to be able to test it before it becomes the new default.
Closes #35901
Draft till CI run https://github.com/graalvm/mandrel/actions/runs/6168707496 completes