Exclude new GraalVM dependencies that are part of GraalVM/Mandrel #35873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerboaa please review |
geoand
approved these changes
Sep 12, 2023
jerboaa
suggested changes
Sep 12, 2023
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java
Show resolved
Hide resolved
zakkak
force-pushed
the
2023-09-12-rm-more-arteftacts
branch
from
78031de to
f1476be
Compare
jerboaa
approved these changes
Sep 12, 2023
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java
Outdated
Show resolved
Hide resolved
oracle/graal#7171 splits graal-sdk in 4 new modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1) we need to remove those as well. Note that it's OK to have them marked for removal even when using GraalVM < 23.1 despite them not actually being present. Closes quarkusio#35872
zakkak
force-pushed
the
2023-09-12-rm-more-arteftacts
branch
from
f1476be to
9838aae
Compare
zakkak
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
zakkak
removed
the
triage/waiting-for-ci
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Nov 30, 2023
When quarkusio#35873 was merged `org.graalvm.polyglot:polyglot` was part of the GraalVM dev builds/releases, but was later completely removed from them.
holly-cummins
pushed a commit
to holly-cummins/quarkus
that referenced
this pull request
Feb 8, 2024
When quarkusio#35873 was merged `org.graalvm.polyglot:polyglot` was part of the GraalVM dev builds/releases, but was later completely removed from them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oracle/graal#7171 splits graal-sdk in 4 new
modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1)
we need to remove those as well. Note that it's OK to have them marked
for removal even when using GraalVM < 23.1 despite them not actually
being present.
Closes #35872
Marked as draft till CI run https://github.com/graalvm/mandrel/actions/runs/6158348245 completes
Update: CI run looks good