-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Elasticsearch/OpenSearch server version for tests and dev services to 8.9/2.9 #35446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @gsmet (elasticsearch,hibernate-search), @loicmathieu (elasticsearch) |
5803e6d
to
01202a4
Compare
01202a4
to
6974d60
Compare
loicmathieu
reviewed
Aug 22, 2023
...elasticsearch/devservices/HibernateSearchElasticsearchDevServicesDisabledImplicitlyTest.java
Outdated
Show resolved
Hide resolved
...elasticsearch/devservices/HibernateSearchElasticsearchDevServicesDisabledExplicitlyTest.java
Show resolved
Hide resolved
loicmathieu
approved these changes
Aug 22, 2023
6974d60
to
1eb4abf
Compare
I added a commit to clarify the names and content of Hibernate Search tests related to dev services. Thanks for the review! |
gsmet
approved these changes
Aug 22, 2023
Failing Jobs - Building 1eb4abf
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: integration-tests/rest-client
📦 integration-tests/rest-client✖
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dependencies
Pull requests that update a dependency file
area/elasticsearch
area/hibernate-search
Hibernate Search
area/logging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating as draft since we need to upgrade Hibernate Search first: #35445=> DoneShould not be backported as this affects the version of Elasticsearch/OpenSearch started by default in dev services, which I think is technically a breaking change.