Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary --pull parameter when running builder images #33766

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jun 1, 2023

Follows up on #33749.

I forgot to remove this code that was just a remainder of an earlier approach which didn't go anywhere
(#33691 (comment)).

Keeping this code could in theory lead to extra pulls when using quarkus.native.build-image.pull='always' (the default) and the image gets updated right while we're building, but more importantly it could lead to extra, unecessary queries to quay.io, so let's avoid that.

Follows up on quarkusio#33749.

I forgot to remove this code that was just a remainder of an earlier
approach which didn't go anywhere
(quarkusio#33691 (comment)).

Keeping this code could in theory lead to extra pulls when using
quarkus.native.build-image.pull='always' (the default) and the image
gets updated right while we're building, but more importantly it could
lead to extra, unecessary queries to quay.io, so let's avoid that.
@yrodiere yrodiere requested a review from cescoffier June 1, 2023 09:46
@quarkus-bot quarkus-bot bot added the area/core label Jun 1, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 1, 2023

Failing Jobs - Building f3f9719

Status Name Step Failures Logs Raw logs
✔️ Devtools Tests - JDK 11
Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ Devtools Tests - JDK 17
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 19
Native Tests - Amazon Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.RESTEasyReactiveCodestartsTest.buildAllProjects line 28 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status is zero] 
expected: 0

📦 integration-tests/devtools/target/quarkus-codestart-test/resteasy-reactive-qute-resteasy-reactive-4bae67bb-34ae-47cb-b6d5-39b60343ad79/real-data/java

ilove.quark.us.GreetingResourceTest.testHelloEndpoint line 15 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

⚙️ Native Tests - Amazon #

- Failing: integration-tests/amazon-lambda integration-tests/amazon-lambda-http 

📦 integration-tests/amazon-lambda

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleIT.testSimpleLambdaSuccess - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use

📦 integration-tests/amazon-lambda-http

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleIT.testJaxrsCognitoJWTSecurityContext - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use

@yrodiere
Copy link
Member Author

yrodiere commented Jun 2, 2023

The test failures look unrelated:

2023-06-01T10:36:31.3033991Z java.net.SocketTimeoutException: Read timed out

And

2023-06-01T11:00:42.8734323Z [error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use

Merging. Thanks for the review(s)!

@yrodiere yrodiere merged commit 164d080 into quarkusio:main Jun 2, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 2, 2023
@yrodiere yrodiere deleted the i33749-followup branch August 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants