Merge pull request #33766 from yrodiere/i33749-followup

Remove unnecessary --pull parameter when running builder images
quarkusio · Jun 2, 2023 · 164d080 · 164d080
2 parents 6c7ce38 + f3f9719
commit 164d080
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java
@@ -495,20 +495,14 @@ enum ImagePullStrategy {
         /**
          * Always pull the most recent image.
          */
-        ALWAYS("always"),
+        ALWAYS,
         /**
          * Only pull the image if it's missing locally.
          */
-        MISSING("missing"),
+        MISSING,
         /**
          * Never pull any image; fail if the image is missing locally.
          */
-        NEVER("never");
-
-        public final String commandLineParamValue;
-
-        ImagePullStrategy(String commandLineParamValue) {
-            this.commandLineParamValue = commandLineParamValue;
-        }
+        NEVER
     }
 }
diff --git a/...oyment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildContainerRunner.java b/...oyment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildContainerRunner.java
@@ -30,8 +30,7 @@ protected NativeImageBuildContainerRunner(NativeConfig nativeConfig) {
         this.nativeConfig = nativeConfig;
         containerRuntime = nativeConfig.containerRuntime().orElseGet(ContainerRuntimeUtil::detectContainerRuntime);
 
-        this.baseContainerRuntimeArgs = new String[] { "--env", "LANG=C", "--rm",
-                "--pull", nativeConfig.builderImage().pull().commandLineParamValue };
+        this.baseContainerRuntimeArgs = new String[] { "--env", "LANG=C", "--rm" };
 
         containerName = "build-native-" + RandomStringUtils.random(5, true, false);
     }