Remove remaining references to javax classes #30154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, these things are not tested but these changes are simple enough.
gsmet
commented
Jan 3, 2023
| @@ -142,7 +142,7 @@ public A build(ClassOutput classOutput) { | |||
|
|
|||
| String name = annotationInstance.name().toString(); | |||
|
|
|||
| // Ljavax/enterprise/util/AnnotationLiteral<Lcom/foo/MyAnnotation;>;Lcom/foo/MyAnnotation; | |||
| // Ljakarta/enterprise/util/AnnotationLiteral<Lcom/foo/MyAnnotation;>;Lcom/foo/MyAnnotation; | |||
There was a problem hiding this comment.
This is just a comment, it won't hurt to change it now.
|
/cc @manovotn(jakarta), @maxandersen(jakarta), @radcortez(jakarta), @Sanne(jakarta) |
|
@geoand could you have a look at the RESTEasy Reactive-related changes? It looks like these things are untested because they are not failing after the rewrite, which currently misses them. |
Failing Jobs - Building ed1105a
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/elytron-undertow
📦 integration-tests/elytron-undertow✖ |
melloware
approved these changes
Jan 3, 2023
geoand
approved these changes
Jan 4, 2023
benkard
added a commit
to benkard/mulkcms2
that referenced
this pull request
Jan 14, 2023
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `2.15.2.Final` -> `2.15.3.Final` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `2.15.2.Final` -> `2.15.3.Final` | --- ### Release Notes <details> <summary>quarkusio/quarkus</summary> ### [`v2.15.3.Final`](https://github.com/quarkusio/quarkus/releases/tag/2.15.3.Final) [Compare Source](quarkusio/quarkus@2.15.2.Final...2.15.3.Final) ##### Complete changelog - [#​30255](quarkusio/quarkus#30255) - Introduce a JSON Stream parser for the reactive rest client - [#​30242](quarkusio/quarkus#30242) - Throw an IllegalStateException with basic info about the provider that failed to provide a resource - [#​30227](quarkusio/quarkus#30227) - SmallRye GraphQL 1.9.1/2.0.1 + config property to control Federation - [#​30218](quarkusio/quarkus#30218) - OIDC documentation fixes - [#​30200](quarkusio/quarkus#30200) - Ensure that Kotlin implementation of QuarkusApplication works properly - [#​30195](quarkusio/quarkus#30195) - Log graphql.execution.AbortExecutionException when it occurs - [#​30190](quarkusio/quarkus#30190) - 2.15.2.Final breaks command mode with main class extends from QuarkusApplication in kotlin - [#​30187](quarkusio/quarkus#30187) - Bump xstream from 1.4.19 to 1.4.20 - [#​30183](quarkusio/quarkus#30183) - Fixing typos in security overview doc - [#​30177](quarkusio/quarkus#30177) - Properly handle SSE comments in RESTEasy Reactive client and server code - [#​30172](quarkusio/quarkus#30172) - Codestarts - Fix flattening of log levels - [#​30169](quarkusio/quarkus#30169) - NullPointerException when sending SSE with comment only - [#​30161](quarkusio/quarkus#30161) - Align behavior for getDeferredIdentity and getIdentity in TestIdentityAssociation - [#​30160](quarkusio/quarkus#30160) - Different behavior in TestIdentityAssociation for getDeferredIdentity and getIdentity - [#​30157](quarkusio/quarkus#30157) - Gradle quarkusDev: don't use test classes dir for app classes - [#​30155](quarkusio/quarkus#30155) - Show how to verify smallrye-jwt issuer in a shared network - [#​30154](quarkusio/quarkus#30154) - Remove remaining references to javax classes - [#​30152](quarkusio/quarkus#30152) - Improve error handling of AbortExecutionException in smallrye-graphql extension - [#​30146](quarkusio/quarkus#30146) - Properly segregate Json MessageBodyReader/Writer classes for server and client - [#​30145](quarkusio/quarkus#30145) - GraphQL federation directives, which allow multiple values, do not match Apollo contract - [#​30142](quarkusio/quarkus#30142) - When disabling name and version for label selectod in k8s, don't remove from labels - [#​30138](quarkusio/quarkus#30138) - Keycloak Dev Services - [#​30132](quarkusio/quarkus#30132) - Register REST Client body parameters for reflection - [#​30119](quarkusio/quarkus#30119) - Enable/disable GraphQL Federation automatically (+ add a config property for it) - [#​30100](quarkusio/quarkus#30100) - Setting `add-version-to-label-selectors: false` removes the app.kubernetes.io/version label - [#​30078](quarkusio/quarkus#30078) - Quarkus Kotlin Native Reactive REST Client not working properly - [#​30061](quarkusio/quarkus#30061) - Adding Kotlin Tests Breaks Kotlin/Java project - [#​30044](quarkusio/quarkus#30044) - Resteasy Reactive Rest Client fails to re-construct large chunks of streamed json (stream+json) and fails deserialization - [#​29998](quarkusio/quarkus#29998) - Bump to smallrye-config 2.13.1 - [#​29918](quarkusio/quarkus#29918) - smallrye-config: Converter<Int> throws IllegalStateException - [#​29609](quarkusio/quarkus#29609) - Remove Reflection replacements, now supported by GraalVM </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v2.15.3.Final`](quarkusio/quarkus-platform@2.15.2.Final...2.15.3.Final) [Compare Source](quarkusio/quarkus-platform@2.15.2.Final...2.15.3.Final) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, these things are not tested but these changes are simple enough.