Feature/OTEL JAX-RS (Resteasy) Span Code function #30073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @brunobat(opentelemetry), @radcortez(opentelemetry) |
arik-dig
changed the title
|
@radcortez , @brunobat can you please review it? |
arik-dig
force-pushed
the
feature/otel-jaxrs-span-code-function
branch
2 times, most recently
from
09ce351 to
86e1cf1
Compare
arik-dig
force-pushed
the
feature/otel-jaxrs-span-code-function
branch
2 times, most recently
from
58a060f to
1a8b060
Compare
brunobat
approved these changes
Jan 2, 2023
|
seems like some integration tests fail: |
|
arik-dig please build that project locally: and check the .../quarkus/integration-tests/micrometer-prometheus/target/ for details on the reports |
geoand
requested changes
Jan 3, 2023
...quarkus/opentelemetry/runtime/tracing/intrumentation/resteasy/OpenTelemetryServerFilter.java
Outdated
Show resolved
Hide resolved
|
@brunobat feel free to ping me about any tracing + RESTEasy Reactive issues / implementation ideas as I only stumbled upon this as part of my general triaging. |
…pace and code.function
arik-dig
force-pushed
the
feature/otel-jaxrs-span-code-function
branch
from
1a8b060 to
db9ecbe
Compare
arik-dig
requested review from
geoand and
brunobat
and removed request for
geoand
geoand
added
the
triage/waiting-for-ci
|
Thanks @geoand ! |
brunobat
approved these changes
Jan 3, 2023
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
@geoand , in which version is it going to be at? |
|
2.16. It's on the milestone associated with the PR. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the standard attributes
code.functionandcode.namespaceto Local Root Span using JAX-RS filterthis PR is proposed based on this extension discussion
replacing PR #29939