[Extension Proposal] digma-quarkus-opentelemetry

[arik-dig]

Description

digma.ai wants to extend the existing quarkus-opentelemetry ,
mainly by adding span attributes for the web controller - and its mapped method (and class).
see OTEL Semantic conventions for Source Code attributes

Interested in this extension, please +1 via the emoji/reaction feature of GitHub (top right).

Repository name

digma-quarkus-opentelemetry

Short description

add span attributes of code.function and code.namespace

Repository Homepage URL

https://quarkiverse.github.io/quarkiverse-docs/digma-quarkus-opentelemetry/dev/

Repository Topics

• quarkus-extension
• opentelemetry

Team Members

• @arik-dig
• @doppleware

GitHub Applications?

• Stale - Automatically close stale Issues and Pull Requests that tend to accumulate during a project

Additional context

No response

[quarkus-bot]

/cc @aloubyansky(extension-proposal), @brunobat(opentelemetry), @gastaldi(extension-proposal), @gsmet(extension-proposal), @maxandersen(extension-proposal), @radcortez(opentelemetry)

[maxandersen]

interesting, but does this require a separate extension to add those items? /cc @brunobat
Also - what is digma specific on this? seems to be more generic ?

On the repo then the recommended naming convention is quarkus-digma-opentelmetry

[radcortez]

It shouldn't require a separate extension. Our strategy with OTel is to put everything in one extension because it would be tricky for the user to know which extensions to add for OTel to work correctly.

I would oppose it if this were a feature outside the OTel specification, but it is part of the OTel spec. I think we should be able to add the span attributes to some of the span instrumenters. Getting the executing method / classname for REST is possible. Not sure about other components.

[arik-dig]

@radcortez , if that is the case I will create a Pull request on the main project on the original extension. ok?

[radcortez]

Sure, please go ahead.

[gastaldi]

Thanks for clarifying this. Closing this issue now