Ensure that file is written on disk for multipart when endpoint expects it #29716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's get #29729 in before this. |
Sgitario
approved these changes
Dec 7, 2022
…ts it With this change, if the JAX-RS endpoint expects a multipart request to contain a file, then that file is always written to disk regardless of whether the content-disposition contains the filename attribute of not. Fixes: quarkusio#20938
|
Merge conflict fixed |
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
|
@geoand @rsvoboda I wasn't able to backport this one properly. It conflicts with another patch and even if the conflicts are fixed there are some test failures. |
|
I am pretty sure we can make a specific backport PR to |
|
But to be honest, this one isn't really needed by Keycloak as they use a different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, if the JAX-RS endpoint expects a multipart request to
contain a file, then that file is always written to disk regardless
of whether the content-disposition contains the filename attribute
of not.
Fixes: #20938
P.S. The implementation is very clean, but I don't see a better way of passing the necessary information to the runtime code