Handling a multipart request part as a file based on the content-type

[pjgg]

Describe the bug

Quarkus 2.13.7.Final
Related to #29725

This issue is still happening on Quarkus 2.13.7.Final although was backported to Quarkus 2.13.6.Final . Is working on Quarkus 2.15.2.Final or main.

Expected behavior

All files regardless to the content-type of a multi-part request are uploaded.

Actual behavior

I am getting the following error:

Request failed: java.lang.NullPointerException: Cannot invoke "java.io.File.toPath()" because "multipartBody.plainTextFile" is null

How to Reproduce?

git clone --branch 2.13 [email protected]:quarkus-qe/quarkus-test-suite.git
cd  quarkus-test-suite/http/jaxrs-reactive

Fails

mvn clean verify -Dit.test=RESTEasyReactiveMultipartIT#testPlainTextFilePartFromMultipart -Dquarkus.platform.version=2.13.7.Final

Works

mvn clean verify -Dit.test=RESTEasyReactiveMultipartIT#testPlainTextFilePartFromMultipart -Dquarkus.platform.version=2.15.2.Final 

Be sure that the test RESTEasyReactiveMultipartIT#testPlainTextFilePartFromMultipart is not disabled

Output of uname -a or ver

Linux ovpn-193-134.brq.redhat.com 6.0.16-300.fc37.x86_64

Output of java -version

openjdk version "17.0.5" 2022-10-18 OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8) OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @FroMage (resteasy-reactive), @Sgitario (resteasy-reactive), @geoand (resteasy-reactive), @stuartwdouglas (resteasy-reactive)

[gsmet]

@pjgg I'm confused. Does it work with 2.13.6.Final? Because Pedro confirmed things were working for him with 2.13.6.Final.

[pjgg]

@gsmet the reproducer is still failing on 2.13.6.Final (but works on 2.15.2.Final) so maybe something else needs to be backported.

[gsmet]

So what I don't understand is that Pedro was positive his issue was fixed in 2.13.6.Final so I'm not sure your test is actually testing exactly the behavior @pedroigor wanted. I know we had other patches related to this issue that we didn't backport though.

[Sgitario]

The test is not working because it's sending a text part. If you change this line to:

MultiPartSpecification textSpec = new MultiPartSpecBuilder(text.getBytes(StandardCharsets.UTF_8))

The test will work in 2.13.6.Final.

This issue was fixed for 2.15.1.Final by #29716, which is not backported.

[geoand]

So should we disable the test in 2.13?

[pedroigor]

Looks like it is a different scenario. The behavior we expect is working fine in 2.13.

[Sgitario]

Closing as not planned.