Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling a multipart request part as a file based on the content-type #29725

Closed
pedroigor opened this issue Dec 7, 2022 · 1 comment · Fixed by #29729
Closed

Handling a multipart request part as a file based on the content-type #29725

pedroigor opened this issue Dec 7, 2022 · 1 comment · Fixed by #29729
Assignees
@pedroigor
Labels
area/rest kind/enhancement New feature or request
Milestone
2.13.6.Final

Comments

@pedroigor
Copy link
Contributor

pedroigor commented Dec 7, 2022 •
edited
Loading

Description

Currently, Resteasy Reactive only handles a multipart request field as a file if the fileName parameter is set.

The proposal here is to also allow handling file parts based on the content-type set to a field.

The main use case for this RFE is programmatically handling multipart requests where fields are obtained directly from the FormData instance associated with the request and their filenames are not known by the application, but only the content-types.

Related to:

Implementation ideas

  • Add a quarkus.http.body.multi-part.file-content-types setting to set a list of content-types that should be used to handle file parts in a multipart request
  • Change MultiPartUploadHandler to recognize the setting above and process parts accordingly to their content-type
@pedroigor pedroigor added the kind/enhancement New feature or request label Dec 7, 2022
@pedroigor pedroigor self-assigned this Dec 7, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 7, 2022

/cc @FroMage, @geoand, @stuartwdouglas

pedroigor added a commit to pedroigor/quarkus that referenced this issue Dec 7, 2022
@pedroigor
Handling a multipart request part as a file based on the content-type
6e90c4e 
Closes quarkusio#29725
pedroigor added a commit to pedroigor/quarkus that referenced this issue Dec 7, 2022
@pedroigor
Handling a multipart request part as a file based on the content-type
615cfb9 
Closes quarkusio#29725
pedroigor added a commit to pedroigor/quarkus that referenced this issue Dec 7, 2022
@pedroigor
Handling a multipart request part as a file based on the content-type
180dacb 
Closes quarkusio#29725
@pedroigor pedroigor mentioned this issue Dec 7, 2022
Merged
pedroigor added a commit to pedroigor/quarkus that referenced this issue Dec 7, 2022
@pedroigor
Handling a multipart request part as a file based on the content-type
f54a303 
Closes quarkusio#29725
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 7, 2022
essobedo pushed a commit to essobedo/quarkus that referenced this issue Dec 12, 2022
@pedroigor @essobedo
Handling a multipart request part as a file based on the content-type
f2ccbfd 
Closes quarkusio#29725
@gsmet gsmet modified the milestones: 2.16 - main, 2.13.6.Final Dec 14, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Dec 14, 2022
@pedroigor @gsmet
Handling a multipart request part as a file based on the content-type
ee18791 
Closes quarkusio#29725

(cherry picked from commit f54a303)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Dec 20, 2022
@pedroigor @gsmet
Handling a multipart request part as a file based on the content-type
f06081f 
Closes quarkusio#29725

(cherry picked from commit f54a303)
@michalvavrik michalvavrik mentioned this issue Dec 23, 2022
Merged
9 tasks
@pjgg pjgg mentioned this issue Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pedroigor pedroigor

Labels
area/rest kind/enhancement New feature or request
Projects
None yet
Milestone
2.13.6.Final
Development

Successfully merging a pull request may close this issue.

Handling a multipart request part as a file based on the content-type pedroigor/quarkus
2 participants
@pedroigor @gsmet