No need to use response methods returning a Future, if not used (part II) #29502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geoand I would like to get the opinion of Vert-x team first, as per the mentioned PR. |
|
@tsegismont Hi Thomas! Do you think this can cause problems similar to |
tsegismont
approved these changes
Nov 28, 2022
...rtx/src/main/java/org/jboss/resteasy/reactive/server/vertx/ResteasyReactiveOutputStream.java
Outdated
Show resolved
Hide resolved
|
Thanks @tsegismont ! Yep we're aware, but we don't know when will happen and the existing users can have this small benefit in the meantime (tiny, but still something :) ) |
franz1981
force-pushed
the
less_future_bright_present
branch
from
6adf11e to
7c4165d
Compare
geoand
approved these changes
Nov 28, 2022
every little bit helps :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #25577 this is saving creating unnecessary garbage (that will live long enough to bother GC, affect performance and force Netty write completions advertising events we are not interested to deal with).