Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to use response methods returning a Future, if not used #25577

Merged
merged 1 commit into from
May 14, 2022

Conversation

franz1981
Copy link
Contributor

@franz1981 franz1981 commented May 14, 2022

This is introducing a small, but noticeable performance improvement while interacting with `WriteStream', both saving few object allocations and useless work to happen.

Existing end methods return Future, that mean adding Netty listeners and creating wrapping Futures: given that are not used, we can get rid of them by passing null; not very elegant but it works

@franz1981
Copy link
Contributor Author

@tsegismont Any chance we could expose (on Vert-x) specific fire-and-forget methods instead of passing null?

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented May 14, 2022

Failing Jobs - Building 4881220

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/hibernate-search-orm-elasticsearch/deployment 
! Skipped: extensions/hibernate-search-orm-coordination-outbox-polling/deployment integration-tests/devmode integration-tests/hibernate-search-orm-elasticsearch and 3 more

📦 extensions/hibernate-search-orm-elasticsearch/deployment

Failed to execute goal io.fabric8:docker-maven-plugin:0.39.1:start (docker-start) on project quarkus-hibernate-search-orm-elasticsearch-deployment: I/O Error

@Sanne Sanne merged commit e731570 into quarkusio:main May 14, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 14, 2022
@gsmet gsmet modified the milestones: 2.10 - main, 2.9.1.Final May 15, 2022
@tsegismont
Copy link
Contributor

@tsegismont Any chance we could expose (on Vert-x) specific fire-and-forget methods instead of passing null?

Sorry no, we've chosen to have two programming models exposed: futurized and callbacks (which was the only one available in earlier versions).

The best way to proceed is what you did, I think: use a null callback.

@franz1981
Copy link
Contributor Author

Thanks @tsegismont to confirm that what I've done is idiomatic with the existing API 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants