Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmodifiableList handling of parameterized tests #28265

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Fix unmodifiableList handling of parameterized tests #28265

merged 1 commit into from
Sep 29, 2022

Conversation

joyrex2001
Copy link
Contributor

In java 17 an unmodifiable list of custom objects as part of an Arguments stream used to result in the below error.
This does not occur when the unmodifiable list contains e.g. a list of strings.

[ERROR] Errors: 
[ERROR]   ParamsTest.methodUnmodifiableListArguments(Object)[1] » Conversion No converter available
---- Debugging information ----
message             : No converter available
type                : java.util.Collections$UnmodifiableRandomAccessList
converter           : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
message[1]          : Unable to make field private static final long java.util.Collections$UnmodifiableCollection.serialVersionUID accessible: module java.base does not "opens java.util" to unnamed module @2d58d9ed
-------------------------------

By adding Collections.unmodifiableList to the CustomListConverter this use case is supported as well.

@gsmet gsmet requested a review from geoand September 28, 2022 18:48
@geoand
Copy link
Contributor

geoand commented Sep 29, 2022

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 29, 2022

Failing Jobs - Building d890527

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/vertx-http/deployment integration-tests/kubernetes/maven-invoker-way integration-tests/opentelemetry-reactive 
! Skipped: extensions/oidc-client-filter/deployment extensions/oidc/deployment extensions/security-webauthn/deployment and 18 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.http2.Http2Test.testHttp2EnabledSsl line 57 - More details - Source on GitHub

java.util.concurrent.ExecutionException: javax.net.ssl.SSLHandshakeException: Failed to create SSL connection
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1999)

📦 integration-tests/kubernetes/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:install (integration-tests) on project quarkus-integration-test-kubernetes-invoker: Failed to install project dependencies: MavenProject: io.quarkus:quarkus-integration-test-kubernetes-invoker:999-SNAPSHOT @ D:\a\quarkus\quarkus\integration-tests\kubernetes\maven-invoker-way\pom.xml

📦 integration-tests/opentelemetry-reactive

io.quarkus.it.opentelemetry.reactive.OpenTelemetryReactiveClientTest.post line 94 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <e5b99f5e65e72acf> but was: <fb7316d58d4c4912>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

@gsmet gsmet merged commit 7372535 into quarkusio:main Sep 29, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 29, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants