Fix unmodifiableList handling of parameterized tests

quarkusio · Sep 28, 2022 · d890527 · d890527
1 parent dad17dd
commit d890527
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/integration-tests/test-extension/tests/src/test/java/io/quarkus/it/extension/ParamsTest.java b/integration-tests/test-extension/tests/src/test/java/io/quarkus/it/extension/ParamsTest.java
@@ -120,6 +120,15 @@ static List<Arguments> testDataListArguments() {
         return Arrays.asList(Arguments.of(new TestData(), "foo"), Arguments.of(new TestData(), "foo"));
     }
 
+    @ParameterizedTest
+    @MethodSource("testDataUnmodifiableListArguments")
+    public void methodUnmodifiableListArguments(Object list) {
+    }
+
+    static Stream<Arguments> testDataUnmodifiableListArguments() {
+        return Stream.of(Arguments.of(Collections.unmodifiableList(List.of(new TestObject3()))));
+    }
+
     @ParameterizedTest
     @MethodSource("testStreamOfMapEntryArguments")
     public void methodList(Map.Entry<String, String> ignore) {
@@ -165,4 +174,10 @@ Map<String, String> getMap() {
         }
 
     }
+
+    static class TestObject3 {
+
+        static final String value = "one";
+
+    }
 }
diff --git a/test-framework/junit5/src/main/java/io/quarkus/test/junit/internal/CustomListConverter.java b/test-framework/junit5/src/main/java/io/quarkus/test/junit/internal/CustomListConverter.java
@@ -25,6 +25,7 @@ public class CustomListConverter extends CollectionConverter {
             List.of().getClass().getName(),
             List.of(Integer.MAX_VALUE).getClass().getName(),
             Arrays.asList(Integer.MAX_VALUE).getClass().getName(),
+            Collections.unmodifiableList(List.of()).getClass().getName(),
             Collections.emptyList().getClass().getName());
 
     public CustomListConverter(Mapper mapper) {