Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single quotes to fix rendering in the all-config guide #28197

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Use single quotes to fix rendering in the all-config guide #28197

merged 1 commit into from
Sep 27, 2022

Conversation

rsvoboda
Copy link
Member

Use single quotes to fix rendering in the all-config guide

Fixes #28196

@rsvoboda rsvoboda requested a review from yrodiere September 26, 2022 10:34
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Sep 26, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 26, 2022

/cc @Sanne, @gsmet, @yrodiere

@rsvoboda rsvoboda mentioned this pull request Sep 26, 2022
Closed
yrodiere
yrodiere approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yrodiere yrodiere added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport-2.13 labels Sep 26, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@Sanne
Copy link
Member

Sanne commented Sep 26, 2022

@yrodiere a quick grep shows a similar problem in extensions/hibernate-search-orm-elasticsearch/runtime/src/main/java/io/quarkus/hibernate/search/orm/elasticsearch/runtime/HibernateSearchElasticsearchRuntimeConfigPersistenceUnit.java

@rsvoboda
Copy link
Member Author

good catch, I can include that too, I did git grep "if Hibernate ORM is enabled"

@quarkus-bot quarkus-bot bot added the area/hibernate-search Hibernate Search label Sep 26, 2022
@rsvoboda
Copy link
Member Author

rsvoboda commented Sep 26, 2022 •
edited
Loading

PR updated,

git grep -e "\`true\`" -e "\`false\`" | grep ConfigItem

gives nada now

yrodiere
yrodiere approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks for the heads-up and quick update!

@geoand geoand merged commit 6234358 into quarkusio:main Sep 27, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 27, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 27, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/persistence OBSOLETE, DO NOT USE kind/bugfix
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging this pull request may close these issues.

all-config guide - incorrect render of default values for hibernate-orm.active and hibernate-envers.active
5 participants
@rsvoboda @Sanne @yrodiere @gsmet @geoand