Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all-config guide - incorrect render of default values for hibernate-orm.active and hibernate-envers.active #28196

Closed
rsvoboda opened this issue Sep 26, 2022 · 4 comments · Fixed by #28197
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

Describe the bug

all-config guide - incorrect render of default values for hibernate-orm.active and hibernate-envers.active

Screenshot 2022-09-26 at 11 32 57

git grep "if Hibernate ORM is enabled" 
extensions/hibernate-envers/runtime/src/main/java/io/quarkus/hibernate/envers/HibernateEnversBuildTimeConfigPersistenceUnit.java:    @ConfigItem(defaultValueDocumentation = "`true` if Hibernate ORM is enabled; `false` otherwise")
extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java:    @ConfigItem(defaultValueDocumentation = "`true` if Hibernate ORM is enabled; `false` otherwise")

Expected behavior

Nicer render of default values for hibernate-orm.active and hibernate-envers.active

Actual behavior

Incorrect render of default values for hibernate-orm.active and hibernate-envers.active

How to Reproduce?

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

Quarkus main

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@rsvoboda rsvoboda added the kind/bug Something isn't working label Sep 26, 2022
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Sep 26, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 26, 2022

/cc @Sanne, @gsmet, @yrodiere

@yrodiere
Copy link
Member

Thanks for reporting.

It seems you already had a look at source code, are you planning to send a PR? I expect this should be a two-liner :) The easiest solution is probably to switch from backticks (`) to single quotes (')

@rsvoboda
Copy link
Member Author

Was thinking about the same. Alternatively we can drop backticks totally, but single quotes are imho better. Will send PR soon.

@rsvoboda
Copy link
Member Author

PR: #28197

@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 27, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants