Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarkus style enhancements: Security overview doc #28106

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Quarkus style enhancements: Security overview doc #28106

merged 1 commit into from
Sep 22, 2022

Conversation

michelle-purcell
Copy link
Contributor

Ref #QDOCS-33

First iteration of edits to enhance the SECURITY ARCHITECTURE AND GUIDES guide and apply some of the recently agreed Quarkus style guidelines as described in the Quarkus contributor guide.

@michelle-purcell michelle-purcell marked this pull request as draft September 20, 2022 18:42
@michelle-purcell
Copy link
Contributor Author

@sberyozkin - I completed a first pass at editing the main overview page in the as-is structure. I have some questions about the content too. Thanks :-)

@michelle-purcell
Copy link
Contributor Author

@sheilamjones - Hey Sheila, thanks for flagging the overlap with PR #27176. I made a very minor tweak to the OIDC section that you already perfected, mainly to move the links into a table. What do you think? I can reverse if this breaks what you had agreed with SMEs. Thanks :-)

@sberyozkin
Copy link
Member

Thanks for a quality PR, @michelle-purcell, I left a few minor suggestions but overall it all looks very good IMHO

@michelle-purcell michelle-purcell force-pushed the QDOCS-33 branch 4 times, most recently from e7d89cb to 473801f Compare September 21, 2022 16:11
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Sep 21, 2022
@michelle-purcell michelle-purcell force-pushed the QDOCS-33 branch 3 times, most recently from 31d02bc to 8a9c1d3 Compare September 21, 2022 16:35
@michelle-purcell
Copy link
Contributor Author

@sberyozkin - Thank you so much for your review and feedback. I have applied all of your suggestions and fixed the other comments.

@michelle-purcell
Quarkus style enhancements: Security overview doc
cc483e3 
Heading fix

SME Review fixes

Fix SME comments

More SME fixes

Further updates

Fixed minor issues

Moved section up

Bad spacing
@michelle-purcell michelle-purcell marked this pull request as ready for review September 22, 2022 14:56
@sberyozkin
Copy link
Member

Thanks @michelle-purcell :-)

@sberyozkin sberyozkin merged commit d07c866 into quarkusio:main Sep 22, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 22, 2022
@sberyozkin
Copy link
Member

@gsmet Hi Guillaume, not sure why the bot has added an agroal label, have a look please

@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees

@sberyozkin sberyozkin

@sheilamjones sheilamjones

Labels
area/agroal area/dependencies Pull requests that update a dependency file area/documentation
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@michelle-purcell @sberyozkin @gsmet @sheilamjones