Rest-Client-Reactive: Allow FormParams to be used in BeanParams #23099

fwippe · 2022-01-21T16:09:10Z

This PR ensures that @FormParams are taken into account when parsing @BeanParams at Rest Client Reactive interface stubs.

@geoand I certainly imagined the change to be simpler. Please take a closer look at the changes regarding the BeanParamParser; I tried to simplify the parameter extraction, hopefully easing the way for upcoming additional param type integrations.

geoand · 2022-01-21T16:20:27Z

Thanks!

As this is for the client, I'll defer to @michalszynkiewicz for the review

quarkus-bot · 2022-01-21T16:27:39Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `4cf0ec9`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 11 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-rest-client-reactive-deployment: File '/home/runner/work/quarkus/quarkus/extensions/resteasy-reactive/rest-client-reactive/deployment/src/test/java/io/quarkus/rest/client/reactive/beanparam/BeanFormParamTest.java' has not been previously formatted. Please format file and commit before running validation!

quarkus-bot · 2022-01-21T17:22:04Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `58cca89`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 11 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-rest-client-reactive-deployment: File '/home/runner/work/quarkus/quarkus/extensions/resteasy-reactive/rest-client-reactive/deployment/src/test/java/io/quarkus/rest/client/reactive/beanparam/BeanFormParamTest.java' has not been previously formatted. Please format file and commit before running validation!

quarkus-bot · 2022-01-23T21:44:46Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `db94e76`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

quarkus-bot · 2022-01-24T08:06:38Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `c19610f`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 11	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 17	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	MicroProfile TCKs Tests	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data1	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data2	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data3	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data4	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data5	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data6	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data7	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - HTTP	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Messaging1	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc1	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc3	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc4	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Security2	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Spring	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - gRPC	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs

fwippe · 2022-01-24T08:13:29Z

Gradle build failed (probably not because of my changes). I rebased to the latest commit, let's see if it helps...
Update: all checks successful 👍

quarkus-bot · 2022-01-24T08:15:07Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `49ba198`

Status	Name	Failures	Logs	Raw logs
⌛	Initial JDK 11 Build	⚠️ Check →	Logs	Raw logs
⌛	Attach pull request number	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	⚠️ Check →	Logs	Raw logs

fwippe · 2022-01-26T08:57:34Z

Update: Added cycle detection for recursive @BeanParam parsing and took recent changes of @geoand for issue #23034 into account

fwippe · 2022-01-27T08:32:08Z

@michalszynkiewicz Have you perhaps had a chance to look at it yet? What do you think? Anything missing? Certainly, I'm open for discussion!
Considering that the @BeanParam documentation uses @FormParams as example, this PR covers a fairly basic need.

...ve/deployment/src/test/java/io/quarkus/rest/client/reactive/beanparam/BeanFormParamTest.java

michalszynkiewicz · 2022-01-28T11:41:17Z

It looks good to me, it would be great to have a test for form param + param converter + bean param. But I think it can be added in a separate PR. Let me know if you have time to add it to this one soon, otherwise I'll merge it

fwippe · 2022-01-28T15:02:27Z

Included convertable @FormParam type in BeanFormParamTest

quarkus-bot · 2022-01-28T15:18:21Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `a8bc3a3`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: docs extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 11 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-rest-client-reactive-deployment: File '/home/runner/work/quarkus/quarkus/extensions/resteasy-reactive/rest-client-reactive/deployment/src/test/java/io/quarkus/rest/client/reactive/beanparam/BeanFormParamTest.java' has not been previously formatted. Please format file and commit before running validation!

quarkus-bot · 2022-01-28T16:40:33Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b849cfc`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.ModuleWithParentDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

fwippe · 2022-01-28T16:42:40Z

The Gradle build failed, but I don't think it's related to this PR.

fwippe · 2022-01-29T12:51:52Z

I rebased to latest HEAD, all checks passed

michalszynkiewicz · 2022-01-29T14:42:07Z

thanks @fwippe !

geoand · 2022-01-29T14:43:19Z

@michalszynkiewicz I assume we want to backport this to 2.7, right?

quarkus-bot bot added the area/rest label Jan 21, 2022

fwippe mentioned this pull request Jan 21, 2022

Resteasy reactive - missing @Form annotation #23072

Closed

fwippe force-pushed the beanparam_formparam branch from 4cf0ec9 to 58cca89 Compare January 21, 2022 16:54

fwippe force-pushed the beanparam_formparam branch 3 times, most recently from ce9aafd to db94e76 Compare January 23, 2022 20:25

geoand requested a review from michalszynkiewicz January 24, 2022 06:10

fwippe force-pushed the beanparam_formparam branch from db94e76 to c19610f Compare January 24, 2022 07:36

fwippe force-pushed the beanparam_formparam branch from 49ba198 to 759e162 Compare January 24, 2022 08:09

fwippe force-pushed the beanparam_formparam branch 2 times, most recently from 7dd7f7d to 87b1879 Compare January 26, 2022 08:54

michalszynkiewicz reviewed Jan 28, 2022

View reviewed changes

...ve/deployment/src/test/java/io/quarkus/rest/client/reactive/beanparam/BeanFormParamTest.java Show resolved Hide resolved

fwippe force-pushed the beanparam_formparam branch 2 times, most recently from 8a6c08e to a8bc3a3 Compare January 28, 2022 14:58

fwippe force-pushed the beanparam_formparam branch from a8bc3a3 to b849cfc Compare January 28, 2022 15:20

fwippe force-pushed the beanparam_formparam branch from b849cfc to b278da0 Compare January 29, 2022 11:27

Rest-Client-Reactive: Allow FormParams to be used in BeanParams

bb8091d

fwippe force-pushed the beanparam_formparam branch from b278da0 to bb8091d Compare January 29, 2022 11:29

michalszynkiewicz approved these changes Jan 29, 2022

View reviewed changes

michalszynkiewicz merged commit 92c0468 into quarkusio:main Jan 29, 2022

quarkus-bot bot added this to the 2.8 - main milestone Jan 29, 2022

michalszynkiewicz added the triage/backport? label Jan 29, 2022

gsmet modified the milestones: 2.8 - main, 2.7.1.Final Jan 31, 2022

gsmet removed the triage/backport? label Jan 31, 2022

Rest-Client-Reactive: Allow FormParams to be used in BeanParams #23099

Rest-Client-Reactive: Allow FormParams to be used in BeanParams #23099

Conversation

fwippe commented Jan 21, 2022

geoand commented Jan 21, 2022

quarkus-bot bot commented Jan 21, 2022 • edited Loading

Failing Jobs - Building 4cf0ec9

Failures

⚙️ Initial JDK 11 Build #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

quarkus-bot bot commented Jan 21, 2022 • edited Loading

Failing Jobs - Building 58cca89

Failures

⚙️ Initial JDK 11 Build #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

quarkus-bot bot commented Jan 23, 2022 • edited Loading

Failing Jobs - Building db94e76

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

quarkus-bot bot commented Jan 24, 2022 • edited Loading

Failing Jobs - Building c19610f

fwippe commented Jan 24, 2022 • edited Loading

quarkus-bot bot commented Jan 24, 2022 • edited Loading

Failing Jobs - Building 49ba198

fwippe commented Jan 26, 2022

fwippe commented Jan 27, 2022

michalszynkiewicz commented Jan 28, 2022

fwippe commented Jan 28, 2022

quarkus-bot bot commented Jan 28, 2022 • edited Loading

Failing Jobs - Building a8bc3a3

Failures

⚙️ Initial JDK 11 Build #

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

quarkus-bot bot commented Jan 28, 2022 • edited Loading

Failing Jobs - Building b849cfc

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

fwippe commented Jan 28, 2022

fwippe commented Jan 29, 2022

michalszynkiewicz commented Jan 29, 2022

geoand commented Jan 29, 2022

quarkus-bot bot commented Jan 21, 2022 •

edited

Loading

Failing Jobs - Building `4cf0ec9`

quarkus-bot bot commented Jan 21, 2022 •

edited

Loading

Failing Jobs - Building `58cca89`

quarkus-bot bot commented Jan 23, 2022 •

edited

Loading

Failing Jobs - Building `db94e76`

quarkus-bot bot commented Jan 24, 2022 •

edited

Loading

Failing Jobs - Building `c19610f`

fwippe commented Jan 24, 2022 •

edited

Loading

quarkus-bot bot commented Jan 24, 2022 •

edited

Loading

Failing Jobs - Building `49ba198`

quarkus-bot bot commented Jan 28, 2022 •

edited

Loading

Failing Jobs - Building `a8bc3a3`

quarkus-bot bot commented Jan 28, 2022 •

edited

Loading

Failing Jobs - Building `b849cfc`