Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resteasy reactive - missing @Form annotation #23072

Closed
kucharzyk opened this issue Jan 20, 2022 · 9 comments
Closed

Resteasy reactive - missing @Form annotation #23072

kucharzyk opened this issue Jan 20, 2022 · 9 comments
Labels
area/rest kind/bug Something isn't working triage/wontfix This will not be worked on

Comments

@kucharzyk
Copy link
Contributor

Describe the bug

In classic resteasy there is @Form annotation which allow extract form parameters to separate class. It's especially usefull with qute. Endpoints that saves large forms can have many fields. Too many to put them to method signature.

In reasteasy reactive it's missing.

https://docs.jboss.org/resteasy/docs/6.0.0.Final/userguide/html/_Form.html

Expected behavior

Reasteasy reactive should have @Form annotation like reasteasy classic.

Actual behavior

@Form annotation is missing in reasteasy reactive

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@kucharzyk kucharzyk added the kind/bug Something isn't working label Jan 20, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 20, 2022

/cc @FroMage, @geoand, @stuartwdouglas

@kucharzyk
Copy link
Contributor Author

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Jan 21, 2022

Sounds like a useful feature, thanks for reporting!

@fwippe
Copy link
Contributor

fwippe commented Jan 21, 2022

There is already an annotation @BeanParam that IMHO could be used for that. Alas, it doesn't yet support @FormParams. I am going to create a PR to remedy that.

@geoand
Copy link
Contributor

geoand commented Jan 21, 2022

@fwippe you are very correct! I had forgot about @BeanParam since I have never used it myself...

Am pretty sure that it does support @FormParam already. What makes you think it does not?
There is also a test that uses it.

@fwippe
Copy link
Contributor

fwippe commented Jan 21, 2022

@fwippe you are very correct! I had forgot about @BeanParam since I have never used it myself...

Am pretty sure that it does support @FormParam already. What makes you think it does not? There is also a test that uses it.

Because I thought so myself and tried to use it in a company project 🙂 Looking at io.quarkus.jaxrs.client.reactive.deployment.JaxrsClientReactiveProcessor#addBeanParamData there are cases for BeanParam, QueryParam, CookieParam, HeaderParam and PathParam, but no FormParam

@geoand
Copy link
Contributor

geoand commented Jan 21, 2022

Ah, you mean the client, I didn't look at the client code.

If you want to provide a PR to fix that @fwippe, that would be much apprecited.

Thanks

@geoand
Copy link
Contributor

geoand commented Jan 21, 2022

Let's close this one as Won't fix, since @BeanParam seems to cover what is requested.

Sorry for having you open an issue @kucharzyk, I should have remember about @BeanParam.

And thanks @fwippe for stepping up :)

@geoand geoand closed this as completed Jan 21, 2022
@geoand geoand added the triage/wontfix This will not be worked on label Jan 21, 2022
@fwippe
Copy link
Contributor

fwippe commented Jan 21, 2022

For the record: #23099 will enable @FormParams for @BeanParams for the Reactive Rest Client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest kind/bug Something isn't working triage/wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants