Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup with small performance improvements #21681

Merged
merged 5 commits into from
Nov 25, 2021
Merged

Code cleanup with small performance improvements #21681

merged 5 commits into from
Nov 25, 2021

Conversation

rsvoboda
Copy link
Member

Misc code cleanup:

  • f53197e - stream().anyMatch should be faster than .filter().count()
  • 9f8c2e7 - Use .putAll instead of for loop or .forEach
  • 41ff661 - Use optimized List.of instead of Arrays.asList
  • e39103a - Unused imports removal
  • e612094 - Use List.copyOf and List.of instead of Collections.unmodifiableList

@quarkus-bot quarkus-bot bot added area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/elasticsearch area/funqy area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/infinispan Infinispan area/kubernetes area/metrics area/narayana Transactions / Narayana area/oidc area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/rest area/security area/smallrye area/spring Issues relating to the Spring integration area/tracing area/undertow area/vault labels Nov 24, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 24, 2021

/cc @ebullient, @radcortez

gastaldi
gastaldi approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 25, 2021
@geoand geoand merged commit e6ffbe4 into quarkusio:main Nov 25, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 25, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/amazon-lambda area/arc Issue related to ARC (dependency injection) area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/elasticsearch area/funqy area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/infinispan Infinispan area/kubernetes area/metrics area/narayana Transactions / Narayana area/oidc area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/rest area/security area/smallrye area/spring Issues relating to the Spring integration area/tracing area/undertow area/vault
Projects
None yet
Milestone
2.6.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@rsvoboda @gastaldi @radcortez @geoand