Use .putAll instead of for loop or .forEach

quarkusio · Nov 24, 2021 · 9f8c2e7 · 9f8c2e7
1 parent 41ff661
commit 9f8c2e7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/BeanArchiveProcessor.java b/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/BeanArchiveProcessor.java
@@ -109,9 +109,7 @@ private IndexView buildApplicationIndex(ArcConfig config, ApplicationArchivesBui
                 .initBeanDefiningAnnotations(additionalBeanDefiningAnnotations.stream()
                         .map(bda -> new BeanDefiningAnnotation(bda.getName(), bda.getDefaultScope()))
                         .collect(Collectors.toList()), stereotypes);
-        for (DotName customScopeAnnotationName : customScopes.getCustomScopeNames()) {
-            beanDefiningAnnotations.add(customScopeAnnotationName);
-        }
+        beanDefiningAnnotations.addAll(customScopes.getCustomScopeNames());
         // Also include archives that are not bean archives but contain qualifiers or interceptor bindings
         beanDefiningAnnotations.add(DotNames.QUALIFIER);
         beanDefiningAnnotations.add(DotNames.INTERCEPTOR_BINDING);

diff --git a/...e/src/main/java/io/quarkus/funqy/runtime/bindings/knative/events/VertxRequestHandler.java b/...e/src/main/java/io/quarkus/funqy/runtime/bindings/knative/events/VertxRequestHandler.java
@@ -350,9 +350,7 @@ private void processCloudEvent(RoutingContext routingContext) {
                                 responseEvent.put(dsName, outputCloudEvent.dataSchema());
                             }
 
-                            outputCloudEvent.extensions()
-                                    .entrySet()
-                                    .forEach(e -> responseEvent.put(e.getKey(), e.getValue()));
+                            responseEvent.putAll(outputCloudEvent.extensions());
 
                             String dataContentType = outputCloudEvent.dataContentType();
                             if (dataContentType != null) {

diff --git a/...rayana-jta/runtime/src/main/java/io/quarkus/narayana/jta/runtime/NarayanaJtaRecorder.java b/...rayana-jta/runtime/src/main/java/io/quarkus/narayana/jta/runtime/NarayanaJtaRecorder.java
@@ -38,9 +38,7 @@ public void setNodeName(final TransactionManagerConfiguration transactions) {
     public void setDefaultProperties(Properties properties) {
         //TODO: this is a huge hack to avoid loading XML parsers
         //this needs a proper SPI
-        for (Map.Entry<Object, Object> i : System.getProperties().entrySet()) {
-            properties.put(i.getKey(), i.getValue());
-        }
+        properties.putAll(System.getProperties());
 
         try {
             Field field = PropertiesFactory.class.getDeclaredField("delegatePropertiesFactory");

diff --git a/...a/io/quarkus/smallrye/reactivemessaging/runtime/devconsole/DevReactiveMessagingInfos.java b/...a/io/quarkus/smallrye/reactivemessaging/runtime/devconsole/DevReactiveMessagingInfos.java
@@ -40,9 +40,7 @@ public List<DevChannelInfo> get() {
 
                 // Unfortunately, there is no easy way to obtain the connectors metadata
                 Connectors connectors = container.instance(Connectors.class).get();
-                for (Entry<String, Component> entry : connectors.outgoingConnectors.entrySet()) {
-                    publishers.put(entry.getKey(), entry.getValue());
-                }
+                publishers.putAll(connectors.outgoingConnectors);
                 for (Entry<String, Component> entry : connectors.incomingConnectors.entrySet()) {
                     consumers.computeIfAbsent(entry.getKey(), fun)
                             .add(entry.getValue());